Skip to content

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Nov 19, 2018

Do you agree with this advice @karann-msft?

@karann-msft
Copy link
Contributor

In general yes. The overall experience is still being worked on and nuget.org will be fully ready in January. If you would like to move to license expression today, use the latest nuget exe (4.9.x) since it looks at the expression and inserts the generated license url which will point to a template of the license text. At the moment this is the url that is being surfaced on nuget.org and in the search api. By January, nuget.org would interpret the expression directly from the metadata. The url is still useful for old clients or clients that don't recognize the new license yet. Also, Nuget.org can accept license type expression but not file just yet.

Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @JamesNK. You can merge when you're ready.

@JamesNK
Copy link
Member Author

JamesNK commented Nov 19, 2018

The NuGet team has said there are a couple of issues with the new metadata. It feels like it is not quite ready to be recommended.

The change is fine, it should just wait a month or two before being published.

@rpetrusha rpetrusha changed the title Replace licenseUrl with license in recommended NuGet metadata [WIP] Replace licenseUrl with license in recommended NuGet metadata Nov 19, 2018
@mairaw mairaw added the blocked Blocked for some reason label Dec 14, 2018
@JamesNK JamesNK removed the blocked Blocked for some reason label Dec 17, 2018
@JamesNK
Copy link
Member Author

JamesNK commented Dec 17, 2018

re: NuGet/Announcements#32 @anangaur

This is now a recommended thing from NuGet so ready to merge

@mairaw
Copy link
Contributor

mairaw commented Dec 17, 2018

@JamesNK any updates on this one? When do you think this will be published?

@JamesNK JamesNK changed the title [WIP] Replace licenseUrl with license in recommended NuGet metadata Replace licenseUrl with license in recommended NuGet metadata Dec 17, 2018
@JamesNK JamesNK merged commit 5fb8976 into dotnet:master Dec 17, 2018
@JamesNK
Copy link
Member Author

JamesNK commented Dec 17, 2018

@mairaw No changes needed. Merged!

@mairaw
Copy link
Contributor

mairaw commented Dec 17, 2018

I think we posted at the same time. 😄 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants