Skip to content

Conversation

@ForNeVeR
Copy link
Contributor

Summary

Add quotes around runtime values.

Add quotes around runtime values.
@richlander
Copy link
Member

richlander commented Nov 24, 2018

Why would we add quotes? That seems odd to me. The quotes might be there for two reasons:

  • Demonstrate that the data is a string.
  • Convenience for copy pasting it into XML

I'd suggest that the first goal isn't necessary and if it is, we can describe this in a different way. Given that the quotes might already be in a target XML file, I'd suggest that the second goal is questionable.

Thoughts?

@ForNeVeR
Copy link
Contributor Author

Yes, the quotes seem odd indeed, but the neighbour lines have the quotes already. Would you prefer me to remove the quotes from the whole table?

@richlander
Copy link
Member

Yes, the quotes seem odd indeed, but the neighbour lines have the quotes already. Would you prefer me to remove the quotes from the whole table?

That's my feeling. It would be good to hear an opinion from someone else.

@rpetrusha rpetrusha added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Nov 26, 2018
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ForNeVeR, for contributing to the dotnet/docs repo.
Quotation marks are used with attribute values with the version attribute, and they're used with eleven of the 17 attribute values for the sku attribute. Since your PR adds quotation marks to the remaining six possible values of the sku attribute, I'll merge your PR now.

@rpetrusha rpetrusha merged commit 03b0fbd into dotnet:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants