Skip to content

Conversation

@pkulikov
Copy link
Contributor

Rather than fixing the "value types are also nullable" statement (int is not nullable), I've removed the whole paragraph, as this paragraph doesn't fit the intention of the page: provide very high level overview of the C# types (note, the page is a part of C# keywords language reference). The Value types article does a better job to mention nullable value types.

@pkulikov pkulikov requested a review from BillWagner as a code owner November 24, 2018 17:49
- [Pointer types](../../programming-guide/unsafe-code-pointers/pointer-types.md)

Variables that are value types store data, and those that are reference types store references to the actual data. Reference types are also referred to as objects. Pointer types can be used only in [unsafe](unsafe.md) mode.
Variables that are value types store data, and those that are reference types store references to the actual data. Instances of reference types are also referred to as objects. Pointer types can be used only in [unsafe](unsafe.md) mode.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This explanation, in general, isn't really working for me. These concepts are fundamental to both C# and .NET yet this description is very narrow and (IMO) confusing. I clicked on the description provided for reference types. It's a much better description. IMO, it's not a great description for reference types because it re-describes value and reference types again. It should focus on reference types.

I'd suggest we merge this PR and create an issue to address the feedback I've given. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest we merge this PR and create an issue to address the feedback I've given.

Agree that the page under consideration can be improved further. Given its place in the TOC, it should rather describe and reference descendant articles.

The description of value/reference types seems to be more a concern of the "Concepts" part of the docs, not the "Language reference", though of course, they should link each other.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkulikov Want me to run with my feedback or did you intend to do that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richlander please create an issue with your feedback

@BillWagner BillWagner merged commit 37ffa4b into dotnet:master Nov 26, 2018
@pkulikov pkulikov deleted the patch-6 branch November 26, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants