Skip to content

Conversation

@kaushalp
Copy link
Contributor

Summary

added the traceOutputOptions to log Process ID and timestamp.

Fixes #Issue_Number (if available)

added the traceOutputOptions to log Process ID and timestamp
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to the dotnet/docs repo and for adding the additional attribute to the example, @kaushalp I've requested that you make one minor formatting change.

type="System.Diagnostics.TextWriterTraceListener"
initializeData="network.log"
initializeData="network.log"
traceOutputOptions = "ProcessId, DateTime"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with the remaining attributes of <add>, could you remove the spaces that precede and follow the equals sign?

@rpetrusha rpetrusha added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Dec 5, 2018
@rpetrusha
Copy link
Contributor

Thanks, @kaushalp, for making the additional change. We'll merge your PR now. The change should be live on docs.microsoft.com in the next day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotnet-framework/svc networking/subsvc ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants