Update Navigation for "What's New" section in C#. #9360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
changed the title
rpetrusha
approved these changes
Dec 4, 2018
There was a problem hiding this comment.
This looks good, @BillWagner. I've left a few comments for you to consider.
.openpublishing.redirection.json
Outdated
| "redirect_document_id": false | ||
| }, | ||
| { | ||
| "source_path": "docs/csharp/whats-new/index.md", |
There was a problem hiding this comment.
The problem with this redirection is that it needs to be revised for each new version, which is a maintenance issue.
There was a problem hiding this comment.
It would be easier to do the redirection in the index.md file directly
We've strived for hackable URLs throughout the .NET docset. That has sometimes meant we have index.md files in directories where they don't add much value. This PR is an experiment which tries the following with the C# Guide: . Removes `whats-new/index.md` . Redirects that traffic to `whats-new/csharp-7-3` (which is currently the latest version. This PR **does not ** update the TOC.md file, bcause the JavaScript code that hightlights the current page breaks when multiple nodes in the TOC refer to the same file. This PR also **does not** change any other links pointing to the index.md file on the assumption that those links should track the current "laster" version.
A few related changes here: - Incorporate important bits from "what's new" index. - Update hub page with link for "What's New", and remove redundant link. - Fix bad link.
Respond to feedback / Part 1
BillWagner
force-pushed
the
experiment-index-redirects
branch
from
d31597d to
d2ecbd2
Compare
Thraka
reviewed
Dec 10, 2018
| This article provides a history of each major release of the C# language. The C# team is continuing to innovate and add new features. Detailed language feature status, including features considered for upcoming releases can be found [on the dotnet/roslyn repository](https://github.com/dotnet/roslyn/blob/master/docs/Language%20Feature%20Status.md) on GitHub. | ||
|
|
||
| > [!IMPORTANT] | ||
| > The C# language relies on types and method in what the C# specification defines as a *standard library* for some of the features. The .NET platform delivers those types and methods in a number of packages. One example is exception processing. Every `throw` statement or expression is checked to ensure the object being thrown is derived from <xref:System.Exception>. Similarly, every `catch` is checked to ensure that the type being caught is derived from <xref:System.Exception>. Each version may add new requirements. To use the latest language features in older environments, you may need to install specific libraries. These dependencies are documented in the page for each specific version. You can learn more about the [relationships between language and library](relationships-between-language-and-library.md) for background on this dependency. |
There was a problem hiding this comment.
The C# language relies on types and method
s.... I'll edit and fix this 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've strived for hackable URLs throughout the .NET docset. That has sometimes meant we have index.md files in directories where they don't add much value.
This PR makes several navigation changes:
. Removes
whats-new/index.md. Redirects that traffic to
whats-new/csharp-7-3(which is currently the latest version.This PR does not change any other links pointing to the index.md file on the assumption that those links should track the current "laster" version.
Related to #8206