Skip to content

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Dec 5, 2018

Turning feedback mechanism for the design guidelines since we can't edit that content and updating the ms.date to the date that the book was published.
Also changed the author metadata to use one of the book authors and let ms.author be our default value instead.

@mairaw mairaw self-assigned this Dec 5, 2018
@mairaw mairaw added the WIP label Dec 5, 2018
@mairaw mairaw removed the WIP label Dec 5, 2018
@BillWagner
Copy link
Member

Do we have the capability to turn off the edit button on a folder level? If so, I'd add that change too.

@mairaw
Copy link
Contributor Author

mairaw commented Dec 5, 2018

I'd too but no we can't. I'll request that though internally.

Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw. I left a suggestion for you to consider. This is ready to merge.

**✓ DO** make the serialization constructor protected and provide two parameters typed and named exactly as shown in the sample here.

```
```csharp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dotnet dotnet deleted a comment from rpetrusha Dec 5, 2018
@mairaw mairaw merged commit c69df79 into dotnet:master Dec 5, 2018
@mairaw mairaw deleted the design-guidelines branch December 5, 2018 20:58
mairaw added a commit that referenced this pull request Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants