Skip to content

Remove wrong KB link #9516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2018
Merged

Remove wrong KB link #9516

merged 3 commits into from
Dec 11, 2018

Conversation

@mikkelbu
Copy link
Contributor

@mikkelbu mikkelbu commented Dec 10, 2018

Fixes #9167

@mikkelbu mikkelbu requested a review from BillWagner as a code owner December 10, 2018 15:23
rpetrusha
rpetrusha suggested changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mikkelbu, for eliminating the incorrect link as well as for adding instructions on -help. I've suggested some changes to the section that you've added.

BillWagner
BillWagner approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this fix @mikkelbu We appreciate it.

I made one small word change, and I'll :shipit: now.

Thanks again for contributing to docs.

@BillWagner
Copy link
Member

BillWagner commented Dec 11, 2018

@rpetrusha I'll let you give a a final look after the build finishes.

@rpetrusha rpetrusha merged commit 5858989 into dotnet:master Dec 11, 2018
@mikkelbu mikkelbu deleted the patch-1 branch December 11, 2018 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

+2 more reviewers

@jzeferino jzeferino jzeferino left review comments

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikkelbu @BillWagner @jzeferino @rpetrusha