Skip to content

Conversation

@iwasdavid
Copy link
Contributor

Added mutually recursive records example to records documentation

I have added a code example for creating mutually recursive record types as I couldn't find any information about them on the official documentation.

I noticed in the records.md file, some of the snippets were defined in the markdown file but most were in the samples repo. I have added the code inline but can move to the samples repo if desired.

@iwasdavid iwasdavid requested a review from cartermp as a code owner December 18, 2018 21:37
@dnfclas
Copy link

dnfclas commented Dec 18, 2018

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iwasdavid! I love the addition. A few suggestions and then this should be good to go.

cartermp and others added 5 commits December 19, 2018 02:26
Co-Authored-By: iwasdavid <iwasdavid@gmail.com>
Co-Authored-By: iwasdavid <iwasdavid@gmail.com>
Co-Authored-By: iwasdavid <iwasdavid@gmail.com>
Co-Authored-By: iwasdavid <iwasdavid@gmail.com>
@BillWagner
Copy link
Member

build passed, so I'll :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants