Update SKILL.md with obsolete API replacement guidance - #13055
Conversation
Added a guideline to replace obsolete APIs with their replacements, such as using HttpClient instead of WebRequest.
Updated C# modernization guidelines in SKILL.md.
There was a problem hiding this comment.
🟡 Changes recommended
The updated guidance is either less specific or potentially misleading (notably around target-typed new wording and WebRequest → HttpClient being scenario-dependent).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the csharp-snippet-modernization Skill guidance to adjust how snippet modernizations are described, including new guidance around replacing obsolete APIs.
Changes:
- Rewords the guidance around using target-typed object creation (previously “target-typed
new”). - Adds guidance to replace obsolete APIs, with an example suggesting
WebRequest→HttpClient.
File summaries
| File | Description |
|---|---|
| .github/skills/csharp-snippet-modernization/SKILL.md | Updates modernization rules and adds an obsolete-API replacement guideline for future snippet updates. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wadepickett
left a comment
wadepickett
left a comment
There was a problem hiding this comment.
@gewarren: Approved. I am not finding any issues beyond what the copilot review brought up. The line 55 one should be addressed. the line 37 rewording suggestion issue seems a bit optional.
wadepickett
left a comment
wadepickett
left a comment
There was a problem hiding this comment.
@gewarren: Re-approved.
No description provided.