Skip to content

Copy remark about DNS to SendPingAsync #8482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzikm merged 1 commit into from
Oct 10, 2022
Merged

Copy remark about DNS to SendPingAsync #8482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions xml/System.Net.NetworkInformation/Ping.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1771,6 +1771,17 @@
</AssemblyInfo>
<Docs>
<summary>Sends an Internet Control Message Protocol (ICMP) echo message to a computer, and receives a corresponding ICMP echo reply message from that computer as an asynchronous operation.</summary>
<remarks>
<format type="text/markdown"><![CDATA[
## Remarks
These methods do not cause your application's main thread to block. If you want to block while waiting for the ICMP echo reply message, use the <xref:System.Net.NetworkInformation.Ping.Send%2A> methods.
Copy link
Member

@stephentoub stephentoub Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this remark a bit strange. How is this different from any other XxAsync method?

> [!NOTE]
> The IP address returned by any of the <xref:System.Net.NetworkInformation.Ping.SendPingAsync%2A> methods can originate from a malicious remote computer. Do not connect to the remote computer using this. Use DNS to determine the IP address of the machine to which you want to connect.
]]></format>
</remarks>
</Docs>
</MemberGroup>
<Member MemberName="SendPingAsync">
Expand Down