Skip to content

Copy remark about DNS to SendPingAsync #8482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rzikm merged 1 commit into from
Oct 10, 2022
Merged

Copy remark about DNS to SendPingAsync #8482

rzikm merged 1 commit into from
Oct 10, 2022

Conversation

@rzikm
Copy link
Member

@rzikm rzikm commented Oct 10, 2022

Fixes #2651

@rzikm rzikm requested a review from a team as a code owner October 10, 2022 08:09
@rzikm rzikm enabled auto-merge (squash) October 10, 2022 08:09
@ghost ghost assigned rzikm Oct 10, 2022
@ghost ghost added the area-System.Net label Oct 10, 2022
@ghost
Copy link

ghost commented Oct 10, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #2651

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net
Milestone: -

@opbld32
Copy link

opbld32 commented Oct 10, 2022

Learn Build status updates of commit e3cabbd:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.NetworkInformation/Ping.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@rzikm rzikm merged commit 8e409fc into dotnet:main Oct 10, 2022
stephentoub
stephentoub reviewed Oct 10, 2022
View reviewed changes
xml/System.Net.NetworkInformation/Ping.xml
<format type="text/markdown"><![CDATA[
## Remarks
These methods do not cause your application's main thread to block. If you want to block while waiting for the ICMP echo reply message, use the <xref:System.Net.NetworkInformation.Ping.Send%2A> methods.
Copy link
Member

@stephentoub stephentoub Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this remark a bit strange. How is this different from any other XxAsync method?

rzikm added a commit to rzikm/dotnet-api-docs that referenced this pull request Oct 10, 2022
@rzikm
Feedback from dotnet#8482
dd06a2d
rzikm added a commit to rzikm/dotnet-api-docs that referenced this pull request Nov 7, 2022
@rzikm
Feedback from dotnet#8482
548b6be
rzikm added a commit that referenced this pull request Nov 7, 2022
@rzikm
Small fixes from post-merge code review. (#8489)
5e04197 
* Feedback from #8467

* Feedback from #8482

* Feedback from #8484

* Feedback from #8460

* More fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephentoub stephentoub stephentoub left review comments

@liveans liveans liveans approved these changes

Assignees

@rzikm rzikm

Labels

area-System.Net

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[question] Ping.PingPingAsync DNS resolution-safe?

4 participants

@rzikm @opbld32 @stephentoub @liveans