Merge .NET Monitor Dockerfile from nightly branch#2753
Merged
mthalman merged 4 commits intodotnet:mainfrom Apr 21, 2021
Merged
Conversation
ghost
added
the
area-dockerfiles
jander-msft
reviewed
Apr 20, 2021
Contributor
|
@mthalman, everything looks good to me. Do you want me to sign off now or wait until later today when we confirm we're good to go? |
Member
Author
You can approve right now. I'll just wait to hear from you before doing any merging. But even if you've confirmed the release, I wouldn't merge until tomorrow anyway. |
MichaelSimons
approved these changes
Apr 20, 2021
jander-msft
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the Dockerfile, it includes all the associated infra for managing the new variant.