Skip to content

Conversation

@lbussell
Copy link
Member

Fixes #6085, #6817

@lbussell lbussell requested a review from a team as a code owner November 17, 2025 20:00
@lbussell lbussell enabled auto-merge (squash) November 17, 2025 20:00
var commitMessage = $"Update .NET {majorMinorVersionString} to {productVersions["sdk"]} SDK / {productVersions["runtime"]} Runtime";
var commitMessage = releaseConfig switch
{
{ SdkOnly: true } => $"Update .NET {majorMinorVersionString} SDK to {productVersions["sdk"]}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: consider a pattern where "Update .NET {majorMinorVersionString} SDK to {productVersions["sdk"]}" is not duplicated. Benefit increased readability and maintainability.

@lbussell lbussell merged commit 7d84c14 into dotnet:nightly Nov 17, 2025
7 checks passed
@lbussell lbussell deleted the fix-sdk-only-release branch November 17, 2025 22:16
@lbussell lbussell added the needs-backport PR that should be backported to another branch label Dec 3, 2025
lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport PR that should be backported to another branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants