[release/11.0-preview7] Source code updates from dotnet/dotnet - #38703
Merged
wtgodbe merged 9 commits intoJul 29, 2026
Merged
Conversation
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk (Version 11.0.0-beta.26365.101 -> 11.0.0-beta.26376.106) Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Logging, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Formats.Asn1, System.Runtime.Caching, System.Text.Encodings.Web, System.Text.Json (Version 11.0.0-preview.7.26365.101 -> 11.0.0-preview.7.26376.106) [[ commit created by automation ]]
Contributor
Author
|
Note VMR PRs included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
dotnet-maestro
Bot
requested review from
a team,
AndriySvyryd and
wtgodbe
as code owners
July 27, 2026 17:42
wtgodbe
approved these changes
Jul 27, 2026
Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
| VerifyError( | ||
| CoreStrings.UnionTypeNotSupported(nameof(UnionEntity)), | ||
| modelBuilder); | ||
| Assert.Equal( |
Member
There was a problem hiding this comment.
This should be fixed in the product
Member
There was a problem hiding this comment.
No, main is still on preview5
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk (Version 11.0.0-beta.26376.106 -> 11.0.0-beta.26377.110) Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Logging, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Formats.Asn1, System.Runtime.Caching, System.Text.Encodings.Web, System.Text.Json (Version 11.0.0-preview.7.26376.106 -> 11.0.0-preview.7.26377.110) [[ commit created by automation ]]
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk (Version 11.0.0-beta.26377.110 -> 11.0.0-beta.26378.106) Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Logging, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Formats.Asn1, System.Runtime.Caching, System.Text.Encodings.Web, System.Text.Json (Version 11.0.0-preview.7.26377.110 -> 11.0.0-preview.7.26378.106) [[ commit created by automation ]]
This reverts commit 22b6fc6.
This reverts commit 26b6058.
The C# preview "union" language feature now compiles union declarations (e.g. union UnionEntity(int);) as value types (structs implementing System.Runtime.CompilerServices.IUnion), rather than reference types. This broke the existing detection of union types mapped as entity or complex types added in #38398: - SharedTypeExtensions.IsValidEntityType required IsClass: true, so EntityType's constructor now threw a generic ArgumentException ("must be a non-interface reference type") as soon as a union type was added to the model, before ModelValidator ever got a chance to detect it and produce the specific UnionTypeNotSupported message. - ConstructorBindingConvention (an IModelFinalizingConvention that runs during FinalizeModel, before ModelValidator.Validate) attempted to bind a constructor for union types used as complex properties, throwing "No suitable constructor was found" before the model validator's union check was reached. Fix: - IsValidEntityType now also accepts union types (mirroring IsValidComplexType, which already allowed them), so union entity types can still be added to the model and are rejected later, with the intended friendly error message, by ModelValidator. - ConstructorBindingConvention now skips constructor binding for union entity/complex types, since they can never have a meaningful constructor binding, allowing model finalization to proceed to ModelValidator.Validate where the specific union error is thrown. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AndriySvyryd
approved these changes
Jul 28, 2026
wtgodbe
deleted the
darc-release/11.0-preview7-a65431c6-49bf-4887-bb80-a68ad8542e10
branch
July 29, 2026 00:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos
Diff the source with this PR branch