GetOrCreateAsync's factory should use ConfigureAwait

[ladeak]

GetOrCreateAsync's factory should use with ConfigureAwait false, as some UI applications might block on the UI thread.

• Added ConfigureAwait(false) in GetOrCreateAsync
• Added a test to cover the issue.
• Added two helper classes for the tests. Helper classes comments' indicated their original source.

Not sure if tests falls into the 'too hard' category, because of the helper classes.

Addresses #2252

[ladeak]

@anurse and @Tratcher please review this PR.

[ladeak]

@Pilchie please suggest reviewers

[analogrelay]

Looks fine to me, but with a few thoughts/questions.

[davidfowl]

@rynowak had some thoughts about ConfigureAwait in these libraries, specifically that its not worth trying to test all of the code paths and instead use an analyzer to make sure all the places have ConfigureAwait(false).

cc @JamesNK

[ladeak]

@davidfowl , I am happy to with the analyzer instead of tests, could you suggest one?

[JamesNK]

I have setup Microsoft.CodeAnalysis.FxCopAnalyzers in https://github.com/grpc/grpc-dotnet

It comes with a lot of analyzers. I have disabled most of them but ConfigureAwait false is still enabled: https://github.com/grpc/grpc-dotnet/blob/dd72d6a38ab2984fd224aa8ed53686dc0153b9da/Grpc.DotNet.ruleset#L69

[ladeak]

I suppose I need to run GenerateReferenceSource or GenerateReferenceAssemblies to resolve build issues.

[ladeak]

When Directory.Build.target defines the build Reference to FxCopAnalyzer and as well as CodeAnalysisRuleset, I get a build error because ref/*.csproj-s are not updated.

eng/targets/ResolveReferences.targets(200,5): error MSB3245: Could not resolve this reference. Could not locate the package or project for "Microsoft.CodeAnalysis.FxCopAnalyzers". Did you update baselines and dependencies lists? See docs/ReferenceResolution.md for more details.

When I move

  <ItemGroup>
    <Reference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" />
  </ItemGroup>

to Directory.Build.props, and run the script that updates the ref/ projects, then build.cmd, I get the following error:

C:\Users...\source\repos\Extensions.dotnet\sdk\5.0.100-alpha1-015536\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.DefaultItems.targets(256,5): error NETSDK1023: A PackageReference for 'Microsoft.CodeAnalysis.FxCopAnalyzers' was included in your project. This package is implicitly referenced by the .NET SDK and you do not typically need to reference it from your project. For more information, see https://aka.ms/sdkimplicitrefs [C:\Users...\source\repos\Extensions\src\Caching\Abstractions\ref\Microsoft.Extensions.Caching.Abstractions.csproj]

What would be the suggested way to resolve this issue?

[rynowak]

Looks like we probably have to add this to the references list: https://github.com/aspnet/Extensions/blob/master/docs/ReferenceResolution.md#example-adding-a-new-dependency

@anurse @JamesNK - can you help with that?

[analogrelay]

Step 1 and 2 there should be all that's needed, I believe. Adding the <Reference> element to the project and then the <LatestPackageReference> element to the eng/Dependencies.props file. While this package does comes from "another dotnet team", it's dotnet/roslyn-analyzers which is not part of our dependency flow process, so there's no need to go through step 3.

@ladeak let me know if you have any issues making those updates!

[ladeak]

@anurse , I have added the Dependency to the "External dependencies":
https://github.com/aspnet/Extensions/pull/2767/files#diff-8c508e8b957801ef7a859521e59d58b9 but still returns a build error:

eng/targets/ResolveReferences.targets(200,5): error MSB3245: Could not resolve this reference. Could not locate the package or project for "Microsoft.CodeAnalysis.FxCopAnalyzers". Did you update baselines and dependencies lists? See docs/ReferenceResolution.md for more details.

[ladeak]

@anurse Could you suggest, I did those two steps as suggested, but I still get errors.

[ladeak]

@anurse , @Tratcher and @dougbu please complete reviews :)

Stale

[Tratcher]

Thanks