Removing experimental attribute from Http logging middleware#7380
Merged
mariamgerges merged 4 commits intomainfrom Mar 11, 2026
Merged
Removing experimental attribute from Http logging middleware#7380mariamgerges merged 4 commits intomainfrom
mariamgerges merged 4 commits intomainfrom
Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the [Experimental] attribute from the HTTP logging middleware APIs in Microsoft.AspNetCore.Diagnostics.Middleware, promoting them from experimental to stable. The affected types are HttpLoggingServiceCollectionExtensions, IHttpLogEnricher, LoggingRedactionOptions, and the HeadersDataClasses property on RequestHeadersLogEnricherOptions.
Changes:
- Remove
[Experimental]attribute (and associatedDiagnosticIdsusings) fromHttpLoggingServiceCollectionExtensions,IHttpLogEnricher,LoggingRedactionOptions, andRequestHeadersLogEnricherOptions.HeadersDataClasses
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
HttpLoggingServiceCollectionExtensions.cs |
Removes [Experimental] from the extension methods class |
IHttpLogEnricher.cs |
Removes [Experimental] from the enricher interface |
LoggingRedactionOptions.cs |
Removes [Experimental] from the redaction options class |
RequestHeadersLogEnricherOptions.cs |
Removes [Experimental] from the HeadersDataClasses property |
Member
|
for awareness - we are removing the Experimental attribute because the API was reviewed in bulk as part of the initial .NET 8 migration and the API became stable but later the attribute was unnecessarily added again. |
evgenyfedorov2
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow