Skip to content

Removing experimental attribute from Http logging middleware#7380

Merged
mariamgerges merged 4 commits intomainfrom
mariamaziz/http-logging-middleware
Mar 11, 2026
Merged

Removing experimental attribute from Http logging middleware#7380
mariamgerges merged 4 commits intomainfrom
mariamaziz/http-logging-middleware

Conversation

@mariamgerges
Copy link
Copy Markdown
Contributor

@mariamgerges mariamgerges commented Mar 10, 2026

Microsoft Reviewers: Open in CodeFlow

Copilot AI review requested due to automatic review settings March 10, 2026 09:45
@mariamgerges mariamgerges requested a review from a team as a code owner March 10, 2026 09:45
@mariamgerges
Copy link
Copy Markdown
Contributor Author

mariamgerges commented Mar 10, 2026

@Tratcher @geeknoid these APIs were introduced in this PR and I'm not sure if they went through API review or not since this change was 3 years ago. Is it okay to remove the experimental attribute or we should go through API review first?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the [Experimental] attribute from the HTTP logging middleware APIs in Microsoft.AspNetCore.Diagnostics.Middleware, promoting them from experimental to stable. The affected types are HttpLoggingServiceCollectionExtensions, IHttpLogEnricher, LoggingRedactionOptions, and the HeadersDataClasses property on RequestHeadersLogEnricherOptions.

Changes:

  • Remove [Experimental] attribute (and associated DiagnosticIds usings) from HttpLoggingServiceCollectionExtensions, IHttpLogEnricher, LoggingRedactionOptions, and RequestHeadersLogEnricherOptions.HeadersDataClasses

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
HttpLoggingServiceCollectionExtensions.cs Removes [Experimental] from the extension methods class
IHttpLogEnricher.cs Removes [Experimental] from the enricher interface
LoggingRedactionOptions.cs Removes [Experimental] from the redaction options class
RequestHeadersLogEnricherOptions.cs Removes [Experimental] from the HeadersDataClasses property

@evgenyfedorov2
Copy link
Copy Markdown
Member

evgenyfedorov2 commented Mar 11, 2026

for awareness - we are removing the Experimental attribute because the API was reviewed in bulk as part of the initial .NET 8 migration and the API became stable but later the attribute was unnecessarily added again.

@mariamgerges mariamgerges merged commit 0897725 into main Mar 11, 2026
6 checks passed
@mariamgerges mariamgerges deleted the mariamaziz/http-logging-middleware branch March 11, 2026 17:23
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants