LanguageFeature.UseBindingValueDiscard has shipped since F# 6.0 and is enabled for every selectable language version (the minimum accepted --langversion is 8.0). Its feature flag can therefore never be turned off, so it is dead configuration. This issue removes the flag and collapses the guarded code to its enabled behaviour.
What to remove
- The
UseBindingValueDiscard case in LanguageFeatures.fs and LanguageFeatures.fsi
- Its entry in the
features map and its GetFeatureString arm
- The
featureDiscardUseValue string in FSComp.txt
- Every
SupportsFeature LanguageFeature.UseBindingValueDiscard / checkLanguageFeatureAndRecover … UseBindingValueDiscard guard — keep only the enabled path and delete the legacy branch
- Adjust affected tests and baselines accordingly
Consequence: --disableLanguageFeature:UseBindingValueDiscard is no longer a recognised feature name.
Version mapping
|
LanguageFeature.UseBindingValueDiscard, languageVersion60 |
Feature string
|
featureDiscardUseValue,"discard pattern in use binding" |
Part of #20139
LanguageFeature.UseBindingValueDiscardhas shipped since F# 6.0 and is enabled for every selectable language version (the minimum accepted--langversionis 8.0). Its feature flag can therefore never be turned off, so it is dead configuration. This issue removes the flag and collapses the guarded code to its enabled behaviour.What to remove
UseBindingValueDiscardcase inLanguageFeatures.fsandLanguageFeatures.fsifeaturesmap and itsGetFeatureStringarmfeatureDiscardUseValuestring inFSComp.txtSupportsFeature LanguageFeature.UseBindingValueDiscard/checkLanguageFeatureAndRecover … UseBindingValueDiscardguard — keep only the enabled path and delete the legacy branchConsequence:
--disableLanguageFeature:UseBindingValueDiscardis no longer a recognised feature name.Version mapping
fsharp/src/Compiler/Facilities/LanguageFeatures.fs
Line 183 in ea778bb
Feature string
fsharp/src/Compiler/FSComp.txt
Line 1252 in ea778bb
Part of #20139