Perf: Throttle parallel typechecks in Find All References - #20128
Draft
xperiandri wants to merge 2 commits into
Draft
Perf: Throttle parallel typechecks in Find All References#20128xperiandri wants to merge 2 commits into
xperiandri wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20127
Problem
Project.FindFSharpReferencesAsynclaunched oneCancellableTaskper document in the project simultaneously viaCancellableTask.whenAll, causing an unbounded number of parallel typechecks (one per document) at once during Find All References / Rename.Fix
CancellableTask.whenAllThrottled maxDegreeOfParallelisminCancellableTasks.fs, using aSemaphoreSlimto cap concurrency while preserving cancellation semantics.Project.FindFSharpReferencesAsync(WorkspaceExtensions.fs), capping concurrency tomax 1 Environment.ProcessorCount.