Flatten always-on DiagnosticForObjInference language feature

src/Compiler/Checking/TypeRelations.fs

@@ -228,12 +228,10 @@ let ChooseTyparSolutionAndRange (g: TcGlobals) amap (tp:Typar) =
                  (maxTy, isRefined), m
              )
 
-    if g.langVersion.SupportsFeature LanguageFeature.DiagnosticForObjInference then
-        match tp.Kind with
-        | TyparKind.Type ->
-            if not isRefined then
-                informationalWarning(Error(FSComp.SR.typrelNeverRefinedAwayFromTop(), m))
-        | TyparKind.Measure -> ()
+    match tp.Kind with
+    | TyparKind.Type when not isRefined ->
+        informationalWarning(Error(FSComp.SR.typrelNeverRefinedAwayFromTop(), m))
+    | _ -> ()
 
     maxTy, m
 

src/Compiler/FSComp.txt

@@ -1733,7 +1733,6 @@ featureEscapeBracesInFormattableString,"Escapes curly braces before calling Form
 3563,lexInvalidIdentifier,"This is not a valid identifier"
 3564,parsMissingUnionCaseName,"Missing union case name"
 3565,parsExpectingType,"Expecting type"
-featureInformationalObjInferenceDiagnostic,"Diagnostic 3559 (warn when obj inferred) at informational level, off by default"
 featureStaticLetInRecordsDusEmptyTypes,"Allow static let bindings in union, record, struct, non-incremental-class types"
 3566,tcMultipleRecdTypeChoice,"Multiple type matches were found:\n%s\nThe type '%s' was used. Due to the overlapping field names\n%s\nconsider using type annotations or change the order of open statements."
 3567,parsMissingMemberBody,"Expecting member body"

src/Compiler/Facilities/LanguageFeatures.fs

@@ -62,7 +62,6 @@ type LanguageFeature =
     | ExtendedStringInterpolation
     | WarningWhenMultipleRecdTypeChoice
     | ImprovedImpliedArgumentNames
-    | DiagnosticForObjInference
     | ConstraintIntersectionOnFlexibleTypes
     | StaticLetInRecordsDusEmptyTypes
     | WarningWhenTailRecAttributeButNonTailRecUsage
@@ -196,7 +195,6 @@ type LanguageVersion(versionText, ?disabledFeaturesArray: LanguageFeature array)
                 LanguageFeature.ExtendedStringInterpolation, languageVersion80
                 LanguageFeature.WarningWhenMultipleRecdTypeChoice, languageVersion80
                 LanguageFeature.ImprovedImpliedArgumentNames, languageVersion80
-                LanguageFeature.DiagnosticForObjInference, languageVersion80
                 LanguageFeature.WarningWhenTailRecAttributeButNonTailRecUsage, languageVersion80
                 LanguageFeature.StaticLetInRecordsDusEmptyTypes, languageVersion80
                 LanguageFeature.ConstraintIntersectionOnFlexibleTypes, languageVersion80
@@ -401,8 +399,6 @@ type LanguageVersion(versionText, ?disabledFeaturesArray: LanguageFeature array)
         | LanguageFeature.ExtendedStringInterpolation -> FSComp.SR.featureExtendedStringInterpolation ()
         | LanguageFeature.WarningWhenMultipleRecdTypeChoice -> FSComp.SR.featureWarningWhenMultipleRecdTypeChoice ()
         | LanguageFeature.ImprovedImpliedArgumentNames -> FSComp.SR.featureImprovedImpliedArgumentNames ()
-        | LanguageFeature.DiagnosticForObjInference -> FSComp.SR.featureInformationalObjInferenceDiagnostic ()
-
         | LanguageFeature.StaticLetInRecordsDusEmptyTypes -> FSComp.SR.featureStaticLetInRecordsDusEmptyTypes ()
         | LanguageFeature.ConstraintIntersectionOnFlexibleTypes -> FSComp.SR.featureConstraintIntersectionOnFlexibleTypes ()
         | LanguageFeature.WarningWhenTailRecAttributeButNonTailRecUsage -> FSComp.SR.featureChkNotTailRecursive ()

src/Compiler/Facilities/LanguageFeatures.fsi

@@ -52,7 +52,6 @@ type LanguageFeature =
     | ExtendedStringInterpolation
     | WarningWhenMultipleRecdTypeChoice
     | ImprovedImpliedArgumentNames
-    | DiagnosticForObjInference
     | ConstraintIntersectionOnFlexibleTypes
     | StaticLetInRecordsDusEmptyTypes
     | WarningWhenTailRecAttributeButNonTailRecUsage