Skip to content

Remove always-on InitPropertiesSupport language feature flag - #20316

Merged
T-Gro merged 3 commits into
mainfrom
fix/issue-20169
Aug 26, 2026
Merged

Remove always-on InitPropertiesSupport language feature flag#20316
T-Gro merged 3 commits into
mainfrom
fix/issue-20169

Conversation

@T-Gro

@T-Gro T-Gro commented Aug 21, 2026

Copy link
Copy Markdown
Member

Fixes #20169

InitPropertiesSupport has shipped enabled since F# 7.0 and the minimum accepted --langversion is 8.0, so the flag could never be turned off. Removed the dead flag and collapsed the guard to its enabled behavior. --disableLanguageFeature:InitPropertiesSupport is no longer a recognized feature name.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 21, 2026
@github-actions github-actions Bot added the AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed label Aug 21, 2026
The InitPropertiesSupport language feature was gated to F# 7.0 and is
effectively always enabled at the compiler's default language version.
Remove the feature flag entirely and collapse its single enforcement site
(CheckInitProperties) to the unconditional path, dropping the now-dead
TcGlobals argument. The init-only-property setter diagnostic still fires
unconditionally, so behavior is unchanged.

Fixes #20169

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@T-Gro
T-Gro enabled auto-merge (squash) August 24, 2026 13:45
@T-Gro
T-Gro requested a review from abonie August 24, 2026 13:45
@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Aug 24, 2026
# Conflicts:
#	src/Compiler/xlf/FSComp.txt.cs.xlf
#	src/Compiler/xlf/FSComp.txt.de.xlf
#	src/Compiler/xlf/FSComp.txt.es.xlf
#	src/Compiler/xlf/FSComp.txt.fr.xlf
#	src/Compiler/xlf/FSComp.txt.it.xlf
#	src/Compiler/xlf/FSComp.txt.ja.xlf
#	src/Compiler/xlf/FSComp.txt.ko.xlf
#	src/Compiler/xlf/FSComp.txt.pl.xlf
#	src/Compiler/xlf/FSComp.txt.pt-BR.xlf
#	src/Compiler/xlf/FSComp.txt.ru.xlf
#	src/Compiler/xlf/FSComp.txt.tr.xlf
#	src/Compiler/xlf/FSComp.txt.zh-Hans.xlf
#	src/Compiler/xlf/FSComp.txt.zh-Hant.xlf
@T-Gro
T-Gro requested a review from abonie August 25, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Remove always-on language feature flag: InitPropertiesSupport

2 participants