Remove always-on InitPropertiesSupport language feature flag - #20316
Merged
Conversation
Contributor
|
The InitPropertiesSupport language feature was gated to F# 7.0 and is effectively always enabled at the compiler's default language version. Remove the feature flag entirely and collapse its single enforcement site (CheckInitProperties) to the unconditional path, dropping the now-dead TcGlobals argument. The init-only-property setter diagnostic still fires unconditionally, so behavior is unchanged. Fixes #20169 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
enabled auto-merge (squash)
August 24, 2026 13:45
abonie
approved these changes
Aug 24, 2026
# Conflicts: # src/Compiler/xlf/FSComp.txt.cs.xlf # src/Compiler/xlf/FSComp.txt.de.xlf # src/Compiler/xlf/FSComp.txt.es.xlf # src/Compiler/xlf/FSComp.txt.fr.xlf # src/Compiler/xlf/FSComp.txt.it.xlf # src/Compiler/xlf/FSComp.txt.ja.xlf # src/Compiler/xlf/FSComp.txt.ko.xlf # src/Compiler/xlf/FSComp.txt.pl.xlf # src/Compiler/xlf/FSComp.txt.pt-BR.xlf # src/Compiler/xlf/FSComp.txt.ru.xlf # src/Compiler/xlf/FSComp.txt.tr.xlf # src/Compiler/xlf/FSComp.txt.zh-Hans.xlf # src/Compiler/xlf/FSComp.txt.zh-Hant.xlf
abonie
approved these changes
Aug 26, 2026
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20169
InitPropertiesSupporthas shipped enabled since F# 7.0 and the minimum accepted--langversionis 8.0, so the flag could never be turned off. Removed the dead flag and collapsed the guard to its enabled behavior.--disableLanguageFeature:InitPropertiesSupportis no longer a recognized feature name.