Remove always-on WhileBang language feature flag - #20330
Merged
Merged
Conversation
Flatten LanguageFeature.WhileBang to the always-on path: delete the DU case (fs+fsi), its features-map entry and GetFeatureString arm, remove the featureWhileBang FSComp string, regenerate xlf, and collapse the pars.fsy enforcement branch. The while! construct itself is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
T-Gro
added
the
NO_RELEASE_NOTES
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
T-Gro
enabled auto-merge (squash)
August 24, 2026 13:45
abonie
approved these changes
Aug 24, 2026
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
Bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20193
while!has shipped since F# 8.0 and the minimum accepted--langversionis 8.0, so theWhileBangfeature flag could never be disabled. Removing it collapses the guard to its always-on path;--disableLanguageFeature:WhileBangis no longer a recognized feature name.