Skip to content

Use source-build-assets repo#20839

Merged
NikolaMilosavljevic merged 5 commits intodotnet:release/8.0.1xxfrom
NikolaMilosavljevic:sbrp.8
Apr 13, 2026
Merged

Use source-build-assets repo#20839
NikolaMilosavljevic merged 5 commits intodotnet:release/8.0.1xxfrom
NikolaMilosavljevic:sbrp.8

Conversation

@NikolaMilosavljevic
Copy link
Copy Markdown
Member

After source-build-reference-packages repo was renamed to source-build-assets, some changes are needed in installer repo to allow proper consumption of the new repo artifacts.

This PR updates repo-related properties or values.

This PR does not update various SBRP-named property names as there is no need for that. While repo was renamed, in .NET 8.0 repo still contains just reference packages, so the infra is correct and isn't confusing.

After this PR is merged and VMR updated, it will likely be necessary to manually delete old repo clone in VMR and potentially old repo's project file in repo-projects. I will prepare a follow up with those changes.

Validation

Installer build
VMR build

Copilot AI review requested due to automatic review settings April 10, 2026 15:28
@NikolaMilosavljevic NikolaMilosavljevic requested a review from a team as a code owner April 10, 2026 15:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates installer/source-build infrastructure to consume the renamed dotnet/source-build-assets repository (formerly dotnet/source-build-reference-packages) by aligning repo mappings, intermediate package IDs, and related build/config paths.

Changes:

  • Switch VMR source mapping and repo references from source-build-reference-packages to source-build-assets.
  • Update source-build packaging/extraction logic to recognize the new intermediate package name/wildcards.
  • Update smoke-test license exclusion paths and Version.Details.xml dependency metadata for the renamed repo.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/VirtualMonoRepo/source-mappings.json Updates the VMR repo mapping name/remote to source-build-assets.
src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/assets/LicenseExclusions.txt Renames excluded paths to match the new repo folder name in VMR.
src/SourceBuild/content/repo-projects/source-build-assets.proj Renames local package-cache directory and NuGet source name to match source-build-assets.
src/SourceBuild/content/repo-projects/package-source-build.proj Updates the intermediate package wildcard to the new Microsoft.SourceBuild.Intermediate.source-build-assets* ID.
src/SourceBuild/content/repo-projects/dotnet.proj Updates the toolset repo reference to source-build-assets.
src/SourceBuild/content/repo-projects/Directory.Build.targets Redirects intermediate package extraction to $(ReferencePackagesDir) based on the new repo/package identifier.
eng/Version.Details.xml Updates dependency name/URI/SHA/version and SourceBuild RepoName to source-build-assets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NikolaMilosavljevic
Copy link
Copy Markdown
Member Author

Investigating VMR-sync issue - the error doesn't make sense, as the dependency is being updated in my change:

fail: Failed to synchronize repo installer
      No source mapping named 'source-build-reference-packages' found for a eng/Version.Details.xml dependency of Microsoft.SourceBuild.Intermediate.source-build-reference-packages.
dbug: System.InvalidOperationException: No source mapping named 'source-build-reference-packages' found for a eng/Version.Details.xml dependency of Microsoft.SourceBuild.Intermediate.source-build-reference-packages

@NikolaMilosavljevic
Copy link
Copy Markdown
Member Author

Investigating VMR-sync issue - the error doesn't make sense, as the dependency is being updated in my change:

fail: Failed to synchronize repo installer
      No source mapping named 'source-build-reference-packages' found for a eng/Version.Details.xml dependency of Microsoft.SourceBuild.Intermediate.source-build-reference-packages.
dbug: System.InvalidOperationException: No source mapping named 'source-build-reference-packages' found for a eng/Version.Details.xml dependency of Microsoft.SourceBuild.Intermediate.source-build-reference-packages

I think this is due to every repo that installer depends on, has a dependency on SBRP repo in the following manner:

    <Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="8.0.0-alpha.1.23451.1">
      <Uri>https://github.com/dotnet/source-build-reference-packages</Uri>
      <Sha>0030d238c7929b0e9b06576837b60ad90037b1d2</Sha>
      <SourceBuild RepoName="source-build-reference-packages" ManagedOnly="true" />
    </Dependency>

I don't think they should have had SourceBuild element, but it is what it is.

The real fix here is to update this dependency in every VMR repo, get that to flow to installer and only then attempts sync again.

@mthalman @MichaelSimons @ellahathaway - do you know of an alternative here? We could technically keep SBRP in source-mappings.json for now, until other repos are fixed - that would unblock the vmr-sync command - it worked in my local test.

@mthalman
Copy link
Copy Markdown
Member

@mthalman @MichaelSimons @ellahathaway - do you know of an alternative here?

I don't know of an alternative.

We could technically keep SBRP in source-mappings.json for now, until other repos are fixed - that would unblock the vmr-sync command - it worked in my local test.

Are you saying make all of these changes except for the change to source-mappings.json?

@NikolaMilosavljevic
Copy link
Copy Markdown
Member Author

@mthalman @MichaelSimons @ellahathaway - do you know of an alternative here?

I don't know of an alternative.

We could technically keep SBRP in source-mappings.json for now, until other repos are fixed - that would unblock the vmr-sync command - it worked in my local test.

Are you saying make all of these changes except for the change to source-mappings.json?

No, I would keep all changes, and in addition add back the source mapping for sbrp repo. It worked in my local test.

I am starting the work on other repos to fixup the dependency, but there are quite a few and they all need to flow before this will work fine - unless I make the change in source-mappings.json.

@NikolaMilosavljevic
Copy link
Copy Markdown
Member Author

NikolaMilosavljevic commented Apr 10, 2026

Added back the source mapping for SBRP repo - necessary until all contributing repos get updated to switch to source-build-assets repo dependency.

@NikolaMilosavljevic
Copy link
Copy Markdown
Member Author

Per offline conversation, I have added exclusion of all files from the old repo with c3b2d6a

@NikolaMilosavljevic NikolaMilosavljevic merged commit fb39dc2 into dotnet:release/8.0.1xx Apr 13, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants