Use source-build-assets repo#20839
Use source-build-assets repo#20839NikolaMilosavljevic merged 5 commits intodotnet:release/8.0.1xxfrom
source-build-assets repo#20839Conversation
There was a problem hiding this comment.
Pull request overview
Updates installer/source-build infrastructure to consume the renamed dotnet/source-build-assets repository (formerly dotnet/source-build-reference-packages) by aligning repo mappings, intermediate package IDs, and related build/config paths.
Changes:
- Switch VMR source mapping and repo references from
source-build-reference-packagestosource-build-assets. - Update source-build packaging/extraction logic to recognize the new intermediate package name/wildcards.
- Update smoke-test license exclusion paths and
Version.Details.xmldependency metadata for the renamed repo.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/VirtualMonoRepo/source-mappings.json | Updates the VMR repo mapping name/remote to source-build-assets. |
| src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/assets/LicenseExclusions.txt | Renames excluded paths to match the new repo folder name in VMR. |
| src/SourceBuild/content/repo-projects/source-build-assets.proj | Renames local package-cache directory and NuGet source name to match source-build-assets. |
| src/SourceBuild/content/repo-projects/package-source-build.proj | Updates the intermediate package wildcard to the new Microsoft.SourceBuild.Intermediate.source-build-assets* ID. |
| src/SourceBuild/content/repo-projects/dotnet.proj | Updates the toolset repo reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/Directory.Build.targets | Redirects intermediate package extraction to $(ReferencePackagesDir) based on the new repo/package identifier. |
| eng/Version.Details.xml | Updates dependency name/URI/SHA/version and SourceBuild RepoName to source-build-assets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Investigating VMR-sync issue - the error doesn't make sense, as the dependency is being updated in my change: |
I think this is due to every repo that I don't think they should have had The real fix here is to update this dependency in every VMR repo, get that to flow to installer and only then attempts sync again. @mthalman @MichaelSimons @ellahathaway - do you know of an alternative here? We could technically keep SBRP in |
I don't know of an alternative.
Are you saying make all of these changes except for the change to |
No, I would keep all changes, and in addition add back the source mapping for sbrp repo. It worked in my local test. I am starting the work on other repos to fixup the dependency, but there are quite a few and they all need to flow before this will work fine - unless I make the change in source-mappings.json. |
|
Added back the source mapping for SBRP repo - necessary until all contributing repos get updated to switch to |
|
Per offline conversation, I have added exclusion of all files from the old repo with c3b2d6a |
After
source-build-reference-packagesrepo was renamed tosource-build-assets, some changes are needed ininstallerrepo to allow proper consumption of the new repo artifacts.This PR updates repo-related properties or values.
This PR does not update various SBRP-named property names as there is no need for that. While repo was renamed, in .NET 8.0 repo still contains just reference packages, so the infra is correct and isn't confusing.
After this PR is merged and VMR updated, it will likely be necessary to manually delete old repo clone in VMR and potentially old repo's project file in
repo-projects. I will prepare a follow up with those changes.Validation
Installer build
VMR build