Use source-build-assets repo#53811
Merged
NikolaMilosavljevic merged 5 commits intodotnet:release/9.0.1xxfrom Apr 13, 2026
Merged
Use source-build-assets repo#53811NikolaMilosavljevic merged 5 commits intodotnet:release/9.0.1xxfrom
source-build-assets repo#53811NikolaMilosavljevic merged 5 commits intodotnet:release/9.0.1xxfrom
Conversation
NikolaMilosavljevic
requested review from
MichaelSimons,
Copilot,
ellahathaway and
mthalman
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the installer/VMR configuration to consume artifacts from the renamed dotnet/source-build-assets repository (formerly source-build-reference-packages).
Changes:
- Renames repository references across VMR source mappings and
repo-projectsdependency graphs. - Updates Source Build infra/config values (repo src dir, NuGet source/cache naming, exclusions) to point at
source-build-assets. - Updates dependency metadata in
eng/Version.Details.xmlto the new repo name/URI/SHA.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/VirtualMonoRepo/source-mappings.json | Updates VMR repo mapping name/remote to source-build-assets. |
| src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/assets/LicenseScanTests/LicenseExclusions.txt | Updates license-scan exclusion paths from old repo folder name to new. |
| src/SourceBuild/content/repo-projects/vstest.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/test-templates.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/templating.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/symreader.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/sourcelink.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/source-build-externals.proj | Switches transitive dependency from old repo name to source-build-assets. |
| src/SourceBuild/content/repo-projects/source-build-assets.proj | Updates SBA-specific comments and cache directory naming. |
| src/SourceBuild/content/repo-projects/sdk.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/scenario-tests.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/runtime.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/roslyn.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/roslyn-analyzers.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/razor.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/msbuild.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/fsharp.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/emsdk.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/Directory.Build.targets | Updates repo exclusion list to exclude source-build-assets. |
| src/SourceBuild/content/repo-projects/Directory.Build.props | Updates SBRP cache NuGet source name value to source-build-assets-cache. |
| src/SourceBuild/content/repo-projects/diagnostics.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/deployment-tools.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/command-line-api.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/cecil.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/aspnetcore.proj | Switches repository reference to source-build-assets. |
| src/SourceBuild/content/repo-projects/arcade.proj | Switches conditional repository reference to source-build-assets. |
| src/SourceBuild/content/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/WriteSbrpUsageReport.cs | Updates reported repo name constant/docs to source-build-assets. |
| src/SourceBuild/content/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/WritePackageVersionsProps.cs | Updates comment reference to the new repo name. |
| src/SourceBuild/content/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/UpdateNuGetConfigPackageSourcesMappings.cs | Updates comments to refer to source-build-assets-cache and SBA build. |
| src/SourceBuild/content/Directory.Build.props | Updates SbrpRepoSrcDir to point at source-build-assets/src. |
| eng/Version.Details.xml | Renames intermediate dependency entry to source-build-assets with updated URI/SHA/version. |
Comments suppressed due to low confidence (1)
src/SourceBuild/content/repo-projects/source-build-assets.proj:5
- The comment path looks incorrect: elsewhere the build defines
$(PrereqsPackagesDir) = prereqs/packages and $ (ReferencePackagesDir) = prereqs/packages/reference, so this should likely say "prereqs/packages/reference" (plural) rather than "prereqs/package/reference".
Comment on lines
+454
to
+457
| <Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-assets" Version="9.0.0-alpha.1.26208.6"> | ||
| <Uri>https://github.com/dotnet/source-build-assets</Uri> | ||
| <Sha>8e19a1b4f607fcbecc4edbd322d77a60d4e25c3c</Sha> | ||
| <SourceBuild RepoName="source-build-assets" ManagedOnly="true" /> |
There was a problem hiding this comment.
Repo rename looks incomplete: leak detection still hard-codes the old repo name ("source-build-reference-packages") when identifying SBRP assemblies (see src/SourceBuild/content/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection/CheckForPoison.cs:364). After switching RepoName here to "source-build-assets", that check likely won’t match anymore; update the hard-coded value (or centralize it) to keep leak detection accurate.
Member
Author
There was a problem hiding this comment.
That is not a repo name - it is an attribute name. We still keep the old attribute name as that one is applied to reference-packages - regardless of how repo is named.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
Same vmr sync error as in 8.0 PR - dotnet/installer#20839 (comment) |
Member
Author
|
Added back the source mapping for SBRP repo - necessary until all contributing repos get updated to switch to |
Member
Author
|
Per offline conversation, I have added exclusion of all files from the old repo with 6747411 |
premun
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
source-build-reference-packagesrepo was renamed tosource-build-assets, some changes are needed ininstallerrepo to allow proper consumption of the new repo artifacts.This PR updates repo-related properties or values.
This PR does not update various SBRP-named property names as there is no need for that. While repo was renamed, in .NET 9.0 repo still contains just reference packages, so the infra is correct and isn't confusing.
After this PR is merged and VMR updated, it will likely be necessary to manually delete old repo clone in VMR and potentially old repo's project file in
repo-projects. I will prepare a follow up with those changes.Validation
SDK build - unrelated failures, present in other CI runs
VMR build