[tests] Remove unnecessary conditional compilation symbol XAMMAC_TESTS.#26254
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the unused XAMMAC_TESTS conditional-compilation symbol from the macOS dotnet monotouch-test project and deletes the now-dead #if !XAMMAC_TESTS guards in shared test configuration code, simplifying the test codepath.
Changes:
- Removed
XAMMAC_TESTSfromDefineConstantsin the macOS dotnet monotouch-test project. - Removed
#if !XAMMAC_TESTS/#endifblocks so the guarded helper APIs are always compiled.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/monotouch-test/dotnet/macOS/monotouch-test.csproj | Stops defining XAMMAC_TESTS for the macOS dotnet monotouch-test project. |
| tests/common/ConfigurationNUnit.cs | Removes !XAMMAC_TESTS preprocessor guards around runtime-identifier and related NUnit helpers. |
| tests/common/Configuration.cs | Removes !XAMMAC_TESTS preprocessor guards around base-library/reference/implementation assembly helpers. |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #3405151] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 203 tests passed 🎉 Tests counts✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
No description provided.