[Testing] Fix net11 CI failure in Picker UI test (Issue34971) - #36873
Merged
Conversation
NafeelaNazhir
temporarily deployed
to
copilot-pat-pool
July 28, 2026 11:09 — with
GitHub Actions
Inactive
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 36873Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 36873" |
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
NafeelaNazhir
temporarily deployed
to
copilot-pat-pool
July 28, 2026 11:10 — with
GitHub Actions
Inactive
NafeelaNazhir
temporarily deployed
to
copilot-pat-pool
July 28, 2026 11:11 — with
GitHub Actions
Inactive
NafeelaNazhir
temporarily deployed
to
copilot-pat-pool
July 28, 2026 11:13 — with
GitHub Actions
Inactive
NafeelaNazhir
temporarily deployed
to
copilot-pat-pool
July 28, 2026 11:14 — with
GitHub Actions
Inactive
NafeelaNazhir
temporarily deployed
to
copilot-pat-pool
July 28, 2026 11:14 — with
GitHub Actions
Inactive
vishnumenon2684
marked this pull request as ready for review
July 28, 2026 13:26
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Issue34971 Picker UI test to handle an iOS behavior change where the picker confirmation button’s accessibility label differs on iOS 26+, preventing iOS UI test timeouts when dismissing the picker dialog.
Changes:
- Added a computed
doneButtonselector that returns"selected"on iOS 26+ and"Done"otherwise. - Updated
CloseOpenedPicker()to usedoneButtonfor iOS/MacCatalyst picker dismissal instead of a hard-coded"Done".
kubaflo
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
On iOS 26, the picker dialog's action button label changed from "Done" to "selected", which broke the
Issue34971UI test that hard-coded the"Done"accessibility id when dismissing thePickerdialog. This PR updates the test to dynamically resolve the correct button label based on the iOS version under test, using the existingHelperExtensions.IsIOS26OrHigherhelper.Changes:
doneButtoncomputed property inIssue34971that returns"selected"on iOS 26+ and"Done"otherwise (viaApp is AppiumIOSApp iosApp && HelperExtensions.IsIOS26OrHigher(iosApp)).App.WaitForElement/App.Tapcalls inCloseOpenedPickerto use this computed value instead of the hard-coded"Done"string.Issue Fixed
Fixes #36857