Skip to content

[Testing] Fix net11 CI failure in Picker UI test (Issue34971) - #36873

Merged
kubaflo merged 1 commit into
dotnet:net11.0from
NafeelaNazhir:net11CIFailures
Jul 28, 2026
Merged

[Testing] Fix net11 CI failure in Picker UI test (Issue34971)#36873
kubaflo merged 1 commit into
dotnet:net11.0from
NafeelaNazhir:net11CIFailures

Conversation

@NafeelaNazhir

@NafeelaNazhir NafeelaNazhir commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

On iOS 26, the picker dialog's action button label changed from "Done" to "selected", which broke the Issue34971 UI test that hard-coded the "Done" accessibility id when dismissing the Picker dialog. This PR updates the test to dynamically resolve the correct button label based on the iOS version under test, using the existing HelperExtensions.IsIOS26OrHigher helper.

Changes:

  • Added a doneButton computed property in Issue34971 that returns "selected" on iOS 26+ and "Done" otherwise (via App is AppiumIOSApp iosApp && HelperExtensions.IsIOS26OrHigher(iosApp)).
  • Updated App.WaitForElement/App.Tap calls in CloseOpenedPicker to use this computed value instead of the hard-coded "Done" string.

Issue Fixed
Fixes #36857

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 36873

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 36873"

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@vishnumenon2684 vishnumenon2684 added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Jul 28, 2026
@Ahamed-Ali Ahamed-Ali added area-testing Unit tests, device tests area-controls-picker Picker labels Jul 28, 2026
@vishnumenon2684
vishnumenon2684 marked this pull request as ready for review July 28, 2026 13:26
Copilot AI review requested due to automatic review settings July 28, 2026 13:26
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Issue34971 Picker UI test to handle an iOS behavior change where the picker confirmation button’s accessibility label differs on iOS 26+, preventing iOS UI test timeouts when dismissing the picker dialog.

Changes:

  • Added a computed doneButton selector that returns "selected" on iOS 26+ and "Done" otherwise.
  • Updated CloseOpenedPicker() to use doneButton for iOS/MacCatalyst picker dismissal instead of a hard-coded "Done".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-controls area-controls-picker Picker area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants