Fix some ScrollView rotation issues on iOS#8570
Merged
mattleibow merged 1 commit intonet6.0from Jul 7, 2022
Merged
Conversation
Add some gallery pages to make testing this stuff easier;
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jsuarezruiz
added
area-layout
mattleibow
approved these changes
Jul 7, 2022
Member
mattleibow
left a comment
mattleibow
left a comment
There was a problem hiding this comment.
Everything seems to be working on both iOS and macOS
Eilon
added
area-controls-scrollview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
On iOS, the ScrollView is sizing itself and it's content incorrectly when the device orientation changes. These changes allow changes in the ScrollView bounds to be laid out correctly after a device rotation.
This also provides a more stable version of the fix from #8451.
Also adds some gallery pages to make testing this stuff easier.
Issues Fixed
Fixes #8447
Also addresses at least some parts of #6499 - once this is merged, we'll revisit that issue.