Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 14134814#13812
Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 14134814#13812dotnet-bot wants to merge 3 commits into
Conversation
…: Build ID 14134814
…: Build ID 14134814
…: Build ID 14134814
There was a problem hiding this comment.
Localization PR Review Summary
Overall: This is an automated OneLocBuild PR that modifies 91 .xlf files across 13 languages. The structural integrity is good, but there is one notable concern.
✅ Checks Passed
- File scope: Only
.xlffiles modified (no code or config changes) - XML structure: Well-formed, proper
trans-unitelements with required attributes - Format placeholders: All
{0},{1}, etc. are preserved correctly between source and target - No suspicious content: No scripts, event handlers, or unexpected URLs
- Legitimate improvements: 223 translations improved, 4 new translations added
⚠️ Concern: 416 Translation Regressions
32 unique resource IDs across all 13 languages are being regressed from state="translated" (with proper localized text) to state="new" (English source copied verbatim) — without any source string change in this diff.
This affects strings in src/Framework, src/MSBuildTaskHost, src/Tasks, src/Build, and src/Utilities. The likely explanation is that the English source strings were updated in a prior commit on this branch and the localization pipeline hasn't re-translated them yet — so it's resetting them to state="new" as expected workflow. However, merging this as-is means non-English users will temporarily see English for these 32 strings.
🟡 Minor: Spacing Issues in Czech
Two Czech translations have missing spaces after format placeholders ({0}nemůže, {1}srozumitelný) which will produce concatenated output at runtime.
Verdict
This appears to be normal OneLocBuild pipeline behavior. The regressions are likely intentional resets for updated source strings pending re-translation. Recommend merging if the team confirms the source string changes are expected on this branch.
Generated by Expert Code Review (on open) for issue #13812 · ● 4.7M
|
@OvesN why was this localization pr created? I thought we disabled it for nonmain |
This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.