Skip to content

Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 14134814#13812

Closed
dotnet-bot wants to merge 3 commits into
vs18.7from
locfiles/5d357380-6d72-4cc6-9ac9-c22bef8f3358
Closed

Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 14134814#13812
dotnet-bot wants to merge 3 commits into
vs18.7from
locfiles/5d357380-6d72-4cc6-9ac9-c22bef8f3358

Conversation

@dotnet-bot
Copy link
Copy Markdown
Contributor

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization PR Review Summary

Overall: This is an automated OneLocBuild PR that modifies 91 .xlf files across 13 languages. The structural integrity is good, but there is one notable concern.

✅ Checks Passed

  • File scope: Only .xlf files modified (no code or config changes)
  • XML structure: Well-formed, proper trans-unit elements with required attributes
  • Format placeholders: All {0}, {1}, etc. are preserved correctly between source and target
  • No suspicious content: No scripts, event handlers, or unexpected URLs
  • Legitimate improvements: 223 translations improved, 4 new translations added

⚠️ Concern: 416 Translation Regressions

32 unique resource IDs across all 13 languages are being regressed from state="translated" (with proper localized text) to state="new" (English source copied verbatim) — without any source string change in this diff.

This affects strings in src/Framework, src/MSBuildTaskHost, src/Tasks, src/Build, and src/Utilities. The likely explanation is that the English source strings were updated in a prior commit on this branch and the localization pipeline hasn't re-translated them yet — so it's resetting them to state="new" as expected workflow. However, merging this as-is means non-English users will temporarily see English for these 32 strings.

🟡 Minor: Spacing Issues in Czech

Two Czech translations have missing spaces after format placeholders ({0}nemůže, {1}srozumitelný) which will produce concatenated output at runtime.

Verdict

This appears to be normal OneLocBuild pipeline behavior. The regressions are likely intentional resets for updated source strings pending re-translation. Recommend merging if the team confirms the source string changes are expected on this branch.

Generated by Expert Code Review (on open) for issue #13812 · ● 4.7M

@JanProvaznik
Copy link
Copy Markdown
Member

@OvesN why was this localization pr created? I thought we disabled it for nonmain

@OvesN
Copy link
Copy Markdown
Contributor

OvesN commented May 19, 2026

@OvesN why was this localization pr created? I thought we disabled it for nonmain

Yeah PR with fix for it was merged here #13690. But I see that in this merge PR the EnableReleaseOneLocBuild was changed to true. 7307392.

I will revert it #13817

@OvesN OvesN closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants