Disable OneLocBuild PRs against non-main branches#13690
Merged
Conversation
Contributor
|
Hello @copilot, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo. |
Agent-Logs-Url: https://github.com/dotnet/msbuild/sessions/7a122f4c-79a6-4666-a84c-44fe928e763c Co-authored-by: OvesN <150850103+OvesN@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update OneLocBuild to disable localization PRs against non-main branches
Disable OneLocBuild PRs against non-main branches
May 5, 2026
Member
|
@copilot variable should have value based on if we're on the main branch |
Agent-Logs-Url: https://github.com/dotnet/msbuild/sessions/1fe0bdc0-5d64-47ae-91df-83d4031c6854 Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
Contributor
Author
JanProvaznik
approved these changes
May 14, 2026
Member
|
@OvesN ptal and merge |
Contributor
There was a problem hiding this comment.
Pull request overview
Disables OneLocBuild loc PRs against vs* release branches by defaulting EnableReleaseOneLocBuild to false, only overriding to true on main (where the release-branch job isn't instantiated anyway, so the override is effectively a no-op but follows the existing conditional-variable pattern used elsewhere in the file).
Changes:
- Default
EnableReleaseOneLocBuildtofalseso thevs*-gated OneLocBuild job'sconditionevaluates false on release branches. - Add a
${{ if eq(Build.SourceBranch, 'refs/heads/main') }}block overriding it totrue(matches surrounding style; has no functional effect since the release-branch loc job is itself gated onrefs/heads/vs).
ViktorHofer
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OneLocBuild pipeline was opening localization PRs against both
mainand activevs*release branches. Loc PRs should only targetmain.Context
.vsts-dotnet.ymlhas two OneLocBuild jobs in the localization stage — one forvs*release branches (gated byEnableReleaseOneLocBuild) and one formain. The release-branch job was enabled, causing unwanted loc PRs against servicing branches.Changes Made
EnableReleaseOneLocBuildnow defaults tofalseand is conditionally overridden totrueonly when on themainbranch, following the same conditional variable pattern used elsewhere in the file.This variable is evaluated at template compilation time (
condition: ${{ variables.EnableReleaseOneLocBuild }}), so onvs*branches the variable resolves tofalseand the release-branch OneLocBuild job is suppressed entirely. Themainbranch job is unaffected.Testing
CI pipeline configuration change only — no code changes.
Notes
The
EnableReleaseOneLocBuildtoggle already existed for this purpose; this PR makes its value branch-conditional rather than a static override.