Add RequestThreadProc context to ETW events - #13978
Merged
AlesProkop merged 8 commits intoJun 26, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enriches MSBuild’s ETW RequestThreadProcStart / RequestThreadProcStop events with request context (project path + request/config identifiers) so traces can be correlated back to the originating build request. It also adds a unit test validating the new event payload shape.
Changes:
- Extend
MSBuildEventSourceRequestThreadProcStart/Stop(EventIds 37/38) to include request context payloads (versioned toVersion = 1). - Emit the enriched ETW events from
RequestBuilder.RequestThreadProc. - Add a unit test asserting the new ETW payload names and values.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Framework/MSBuildEventSource.cs | Adds v1 ETW payloads to RequestThreadProc start/stop events. |
| src/Build/BackEnd/Components/RequestBuilder/RequestBuilder.cs | Populates and emits request context fields into the ETW start/stop events. |
| src/Build.UnitTests/BackEnd/RequestBuilder_Tests.cs | Adds a unit test validating the enriched start/stop ETW payload. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
AR-May
approved these changes
Jun 10, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
@AR-May Should we merge this? |
AlesProkop
approved these changes
Jun 26, 2026
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestThreadProcStart/RequestThreadProcStopRequestBuilderTesting