MT reviewer: flag missing tests for substantive migrations - #14086
Merged
jankratochvilcz merged 1 commit intoJun 17, 2026
Merged
Conversation
Step 4 previously only validated tests that were present in the PR. It never flagged the complete absence of tests when the migration is substantive (TaskEnvironment actively flows through CWD-sensitive paths). This led to reviews approving substantive migrations without any test that would catch a regression (e.g., reverting to TaskEnvironment.Fallback). Now Step 4 first classifies the migration as attribute-only vs substantive, and raises MAJOR when a substantive migration has no decoy-CWD or cross-instance-divergence test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the MT migration reviewer agent guidance to explicitly distinguish “attribute-only” vs “substantive” migrations and to require MT-specific tests only when the migration meaningfully flows TaskEnvironment through CWD-sensitive code paths.
Changes:
- Refines Step 4 to classify migrations as attribute-only vs substantive based on whether
TaskEnvironmentis actually used in hazard-relevant call chains. - Requires a Pattern A/Pattern B regression test for substantive migrations (flags MAJOR if absent), while keeping attribute-only migrations test-optional when the audit is clean.
- Clarifies the “Does NOT Do” section to reflect the new substantive-vs-attribute-only test expectation.
jankratochvilcz
enabled auto-merge (squash)
June 17, 2026 13:32
AlesProkop
approved these changes
Jun 17, 2026
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The MT migration reviewer (Step 4) only validated tests that were present in the PR. It never flagged the absence of tests when the migration is substantive — i.e., when
TaskEnvironmentactively flows through CWD-sensitive call chains (e.g.,Path.GetFullPath(env.GetAbsolutePath(...))).This meant the reviewer could approve a substantive migration with zero test coverage for the MT-specific behavior, missing regressions like accidentally reverting to
TaskEnvironment.Fallback.Fix
Step 4 now:
TaskEnvironmentflows through path-resolving code).Also clarifies the "Does NOT Do" section to explicitly state the converse condition.