Make experimental VS insertion reviewers configurable - #14632
Conversation
Experimental insertions hardcoded `MSBuild` as the reviewer, which pinged
the whole team for one person's experiment.
Reviewers now resolve as: the new queue-time `InsertionReviewers`
parameter, else the alias from the `exp/{alias}/{branchname}` branch
convention, else none (with a warning).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d609599e-76bb-479a-85d4-e59df4f373a6
|
Pushed this to two branches and got https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/765624 (with normal format, correctly assigned to me) and https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/765623 (showing the fallback to no-reviewer-specified works). |
There was a problem hiding this comment.
Pull request overview
Updates the experimental VS insertion pipeline so reviewers are no longer hardcoded to the MSBuild team, reducing unnecessary review notifications by allowing per-experiment ownership to drive reviewer assignment.
Changes:
- Adds a new free-form
InsertionReviewersqueue-time pipeline parameter. - Resolves reviewers via parameter first, then by parsing the
exp/{alias}/{branchname}branch convention, otherwise assigns none and logs a warning. - Routes the resolved value into
MicroBuildInsertVsPayloadvia a runtime variable (FinalInsertionReviewers).
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
I kind of don't like this because now when you create an experimental insertion it's super easy to forget about it and you can't see it in the default view https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequests?_a=mine |
|
If you have your alias in the branch it should be: 
|
Every experimental VS insertion assigned
MSBuildas the reviewer, so the entire team got pinged for one person's one-off experiment. Experimental insertions should be reviewed by whoever owns the experiment.Approach
Reviewers now resolve in this order:
InsertionReviewerspipeline parameter, so reviewers can be chosen at insertion-job-schedule time.exp/{alias}/{branchname}convention.Only
vs-insertion-experimental.ymlchanges. The productionvs-insertion.ymlkeepsMSBuild,VS ProTools.Notes for reviewers
env:block rather than inline${{ }}. Inline expansion is textual substitution into the PowerShell source, and this parameter is free-form user input.