Skip to content

Fix for #179.#520

Merged
clairernovotny merged 1 commit into
dotnet:masterfrom
danielcweber:FixSampleTermination
May 22, 2018
Merged

Fix for #179.#520
clairernovotny merged 1 commit into
dotnet:masterfrom
danielcweber:FixSampleTermination

Conversation

@danielcweber

Copy link
Copy Markdown
Collaborator

This fixes #179: When the sampling-observable would terminate earlier than the source observable, the resulting observable would never terminate.

…he source observable, the resulting observable would never terminate.
@clairernovotny clairernovotny requested a review from ghuntley May 22, 2018 19:55
@clairernovotny clairernovotny added this to the 4.0 milestone May 22, 2018
@clairernovotny clairernovotny merged commit e118c7a into dotnet:master May 22, 2018
@danielcweber danielcweber deleted the FixSampleTermination branch May 22, 2018 20:29
clairernovotny pushed a commit that referenced this pull request May 22, 2018
…he source observable, the resulting observable would never terminate. (#520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sample never completes if the sampler sequence completes before the sampled sequence

3 participants