runtime-libraries enterprise-linux is failing because of missing ninja

[wfurt]

Description

https://dev.azure.com/dnceng-public/public/public%20Team/_build/results?buildId=1286152&view=logs&j=03b95830-93c2-599b-7e4d-1efb940adc28&t=9abf97cd-b4a3-5a26-6cf2-d05ce865f2ef&l=631

__TargetRid: linux-x64
  Setting up directories for build
  Checking prerequisites...
  Unable to locate ninja!
##[error]/repo/src/coreclr/runtime.proj(118,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/repo/src/coreclr/build-runtime.sh" -x64 -release -ci -os linux -ninja -targetrid linux-x64 -cmakeargs "-DCLR_DOTNET_RID=linux-x64" -cmakeargs "-DCLR_DOTNET_HOST_PATH=/repo/.dotnet/dotnet" -cmakeargs "-DCDAC_BUILD_TOOL_BINARY_PATH=/repo/artifacts/bin/coreclr/linux.x64.Release/cdac-build-tool/cdac-build-tool.dll" " exited with code 1.
/repo/src/coreclr/runtime.proj(118,5): error MSB3073: The command ""/repo/src/coreclr/build-runtime.sh" -x64 -release -ci -os linux -ninja -targetrid linux-x64 -cmakeargs "-DCLR_DOTNET_RID=linux-x64" -cmakeargs "-DCLR_DOTNET_HOST_PATH=/repo/.dotnet/dotnet" -cmakeargs "-DCDAC_BUILD_TOOL_BINARY_PATH=/repo/artifacts/bin/coreclr/linux.x64.Release/cdac-build-tool/cdac-build-tool.dll" " exited with code 1.

Build FAILED.

/repo/src/coreclr/runtime.proj(118,5): error MSB3073: The command ""/repo/src/coreclr/build-runtime.sh" -x64 -release -ci -os linux -ninja -targetrid linux-x64 -cmakeargs "-DCLR_DOTNET_RID=linux-x64" -cmakeargs "-DCLR_DOTNET_HOST_PATH=/repo/.dotnet/dotnet" -cmakeargs "-DCDAC_BUILD_TOOL_BINARY_PATH=/repo/artifacts/bin/coreclr/linux.x64.Release/cdac-build-tool/cdac-build-tool.dll" " exited with code 1.
    0 Warning(s)
    1 Error(s)

this is regression from #124041

Reproduction Steps

submit PR that will triger that pipeline e.g. mostly networking

Expected behavior

build works

Actual behavior

build fails with message about missing ninja

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

[MihuBot]

I'm a bot. Here is a possible duplicate issue (I may be wrong):

• Unable to locate ninja #124145

[am11]

Do we want to keep using 18.04 as baseline for enterprise linux? If it's not needed, we can simply upgrade it to 22.04 which already has ninja-build installed, otherwise we can run apt install -y ninja-build in the enterprise linux dockerfile (one-off).

[am11]

Option 1:

diff --git a/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/apacheweb/Dockerfile b/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/apacheweb/Dockerfile
index 8be1402f8d6..7ae947271d9 100644
--- a/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/apacheweb/Dockerfile
+++ b/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/apacheweb/Dockerfile
@@ -1,4 +1,4 @@
-FROM mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04
+FROM mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04
 
 ARG DEBIAN_FRONTEND=noninteractive
 
diff --git a/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/kdc/Dockerfile b/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/kdc/Dockerfile
index 3bfc206c5f0..651db9292a1 100644
--- a/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/kdc/Dockerfile
+++ b/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/kdc/Dockerfile
@@ -1,4 +1,4 @@
-FROM mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04
+FROM mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04
 
 COPY ./kdc/kadm5.acl /etc/krb5kdc/
 COPY ./kdc/kdc.conf /etc/krb5kdc/

Option 2:

diff --git a/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/apacheweb/Dockerfile b/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/apacheweb/Dockerfile
index 8be1402f8d6..c7730a59359 100644
--- a/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/apacheweb/Dockerfile
+++ b/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/apacheweb/Dockerfile
@@ -5,7 +5,7 @@ ARG DEBIAN_FRONTEND=noninteractive
 # Install Kerberos client, apache Negotiate auth plugin, and diagnostics
 RUN apt-get update && \
     apt-get install -y --no-install-recommends apache2 libapache2-mod-auth-kerb procps krb5-user iputils-ping dnsutils nano \
-                                               libapache2-mod-auth-ntlm-winbind samba samba-dsdb-modules samba-vfs-modules
+                                               libapache2-mod-auth-ntlm-winbind samba samba-dsdb-modules samba-vfs-modules ninja-build
 WORKDIR /setup
 
 COPY ./common/krb5.conf /etc/
diff --git a/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/kdc/Dockerfile b/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/kdc/Dockerfile
index 3bfc206c5f0..aabc40adc7f 100644
--- a/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/kdc/Dockerfile
+++ b/src/libraries/Common/tests/System/Net/EnterpriseTests/setup/kdc/Dockerfile
@@ -15,7 +15,7 @@ ARG DEBIAN_FRONTEND=noninteractive
 
 # Install KDC and diagnostic tools
 RUN apt-get update && \
-    apt-get install -y --no-install-recommends krb5-kdc krb5-admin-server iputils-ping dnsutils nano
+    apt-get install -y --no-install-recommends krb5-kdc krb5-admin-server iputils-ping dnsutils nano ninja-build
 
 RUN ./setup-kdc.sh
 

[wfurt]

no we don't. This is something #123702 is trying to fix. And adding Ninja there would not be difficult.

[wfurt]

I failed to merge it as the main keeps changing faster than I can keep up updating the branch ;(

[am11]

adding Ninja there would not be difficult.

Current mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-24.04 already has ninja installed (since dotnet/dotnet-buildtools-prereqs-docker#1584).

[wfurt]

I've been hesitant to jump to 24 because it has broken gssapi NTLM module. But anyway, thanks for the pointers @am11

[wfurt]

should be fixed by #123702