Local native AOT testing workflow is broken

[MichalStrehovsky]

Running the native AOT tests locally was broken in #120949

Build FAILED.

d:\git\runtime4\src\tests\Common\tests.targets(53,5): error MSB3030: Could not copy the file "d:\git\runtime4\artifacts\tests\coreclr\windows.x64.Checked\nativeaot\CustomMainWithStubExe\CustomMainWithStubExe\CustomMainWithStubExe.testResults.xml" because it was not found.
d:\git\runtime4\src\tests\Common\tests.targets(53,5): error MSB3030: Could not copy the file "d:\git\runtime4\artifacts\tests\coreclr\windows.x64.Checked\nativeaot\SmokeTests\PInvoke\PInvoke\PInvoke.testResults.xml" because it was not found.
d:\git\runtime4\src\tests\Common\tests.targets(53,5): error MSB3030: Could not copy the file "d:\git\runtime4\artifacts\tests\coreclr\windows.x64.Checked\nativeaot\SmokeTests\AttributeTrimming\AttributeTrimming\AttributeTrimming.testResults.xml" because it was not found.

repeated many times.

This fixes it for me:

MichalStrehovsky@82bb93f

It is not clear to me why we're making nativeaot subtree special for mobile runs. To be able to ship, we need to run the entire test tree. We cannot ship something that didn't have a full test run. The native AOT subtree is a tiny subset of our quality gates.

Cc @jkoritzinsky @kotlarmilos

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

[dotnet-policy-service]

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

[jkoritzinsky]

The NativeAOT test tree doesn't use the XUnitWrapperGenerator or the Fact attributes and all tests are marked as RequiresProcessIsolation to validate scanner behavior and ensure we don't have "spooky action at a distance" with things like inclusion/trimming of the type loader (as requested previously).

However, we don't support RPI tests on mobile platforms (they're implicitly skipped by design).

The logic your commit deletes effectively disables the nativeaot test tree for mobile platforms as a result.

That also explains why the testResults.xml file isn't found. It's not produced by that test infrastructure.

[MichalStrehovsky]

To be clear, I'm running into this on Windows when targeting Windows.

src\tests\build.cmd nativeaot checked tree nativeaot
src\tests\run.cmd runnativeaottests checked

This doesn't work because we did something weird with native AOT tests to suit mobile.

I don't mind if we were to skip native AOT corner case testing on mobile because of mobile test infra deficiencies. I want to be able to run native AOT tests locally so that copilot can run them when it's iterating on fixes.