GetGenericArguments throws NotSupportedException on ConstructorInfo

[taco-indenbosch]

Description

I would expect MethodBase.GetGenericArguments() to return an empty array when calling on any non-generic method including constructors. A NotSupportedException with the message "Derived classes must provide an implementation" is thrown instead when called on a ConstructorInfo object.

Reproduction Steps

This unit test fails:

namespace TestProject1
{
	[TestClass]
	public sealed class Test1
	{
		[TestMethod]
		public void TestMethod1()
		{
			var ctor = typeof(SimpleClass).GetConstructor(new[] { typeof(int) });
			Assert.IsEmpty(ctor.GetGenericArguments());
		}
	}

	public class SimpleClass
	{

		public SimpleClass(int x)
		{ }

	}
}

I have created a tiny project that reproduces the problem - at least on my machine:

Constructor_GetGenericArguments.zip

Expected behavior

GetGenericArguments() should return an empy array.

Actual behavior

The call throws an exception, seemingly because GetGenericArguments() is not overridden in RuntimeConstructorInfo.

Regression?

No response

Known Workarounds

I check MethodBase.IsGenericMethod first, because this is false for constructors; I can then assume that GetGenericArguments() is empty.

Configuration

.NET version: 10.0.203
OS version: Windows 11 Pro 22H2
CPU architecture: x64

Other information

No response

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

[steveisok]

@jkotas I put up a PR for this, but it would be a breaking change if we took it. I imagine our original intent was to throw to make it super apparent and not be misleading with an empty array.

[jkotas]

Replacing an exception with reasonable behavior is allowed change: https://github.com/dotnet/runtime/blob/main/docs/coding-guidelines/breaking-change-rules.md#exceptions . I do not see a problem with fixing this.