[ci-scan-feedback] Validate ActiveIssue overloads; strengthen do-not-disable signal detection

[github-actions]

Triggering signals

• (PR [ci-scan] Skip HostTests Moq tests on iossimulator (refs #128405) #128469, maintainer @svick: "Fix the compile error: Argument 3: cannot convert from 'Xunit.TestRuntimes' to 'Xunit.TargetFrameworkMonikers'", [ci-scan] Skip HostTests Moq tests on iossimulator (refs #128405) #128469 (comment))
• (PR [ci-scan] Skip stackoverflowtester under interpreter mode (refs #127899) #128737, maintainer @janvorli: "This issue needs to be understood... I don't think we should disable the test without trying to understand the problem", [ci-scan] Skip stackoverflowtester under interpreter mode (refs #127899) #128737 (comment))
• (PR [ci-scan] Skip stackoverflowtester under interpreter mode (refs #127899) #128737, maintainer @BrzVlad: "I'm also very aggressive with fixing these pipelines without disabling any tests", [ci-scan] Skip stackoverflowtester under interpreter mode (refs #127899) #128737 (comment))

Proposed edits

• (.github/workflows/ci-failure-scan.md:262, strengthen Step 4.7 to also read referenced issues' comments for do-not-disable signals — tied to PR [ci-scan] Skip stackoverflowtester under interpreter mode (refs #127899) #128737)
• (.github/workflows/ci-failure-scan.md:389-390, document full ActiveIssue 4-parameter constructor overload to prevent positional argument errors — tied to PR [ci-scan] Skip HostTests Moq tests on iossimulator (refs #128405) #128469)
• (.github/workflows/ci-failure-scan.md:402-405, add pre-emit compile-validation checklist for test-disable PRs — tied to PR [ci-scan] Skip HostTests Moq tests on iossimulator (refs #128405) #128469)

Expected behavior change

The next run will avoid emitting test-disable PRs with incorrect ActiveIssue constructor calls (no more TestRuntimes in the TargetFrameworkMonikers slot), and will correctly detect "don't disable" / "will investigate" signals on root-cause issues referenced by the KBE, preventing premature test-disables for failures that maintainers want investigated.

Generated by CI Outer-Loop Failure Scanner — Feedback · ● 8.1M · ◷

---

Note

This was originally intended as a pull request, but the git push operation failed.

Workflow Run: View run details and download patch artifact

The patch file is available in the agent artifact in the workflow run linked above.

To create a pull request with the changes:

# Download the artifact from the workflow run
gh run download 26633745456 -n agent -D /tmp/agent-26633745456

# Create a new branch
git checkout -b ci-scan-feedback/overload-and-do-not-disable-20260529-c860dfaca62439a8

# Apply the patch (--3way handles cross-repo patches where files may already exist)
git am --3way /tmp/agent-26633745456/aw-ci-scan-feedback-overload-and-do-not-disable-20260529.patch

# Push the branch to origin
git push origin ci-scan-feedback/overload-and-do-not-disable-20260529-c860dfaca62439a8

# Create the pull request
gh pr create --title '[ci-scan-feedback] Validate ActiveIssue overloads; strengthen do-not-disable signal detection' --base main --head ci-scan-feedback/overload-and-do-not-disable-20260529-c860dfaca62439a8 --repo dotnet/runtime

Show patch preview (57 of 57 lines)

From c107fcfa2542404642b05fce4b836a324f9f1d77 Mon Sep 17 00:00:00 2001
From: "github-actions[bot]" <github-actions[bot]@users.noreply.github.com>
Date: Fri, 29 May 2026 11:12:43 +0000
Subject: [PATCH] [ci-scan-feedback] Validate ActiveIssue overloads; read
 referenced issue for do-not-disable signals

- Add explicit ActiveIssue constructor signature documentation with the
  full 4-parameter overload so the scanner doesn't place TestRuntimes in
  the TargetFrameworkMonikers slot (caused compile errors in PR #128469).
- Add a pre-emit compile-validation checklist for test-disable PRs.
- Strengthen Step 4.7 to also read comments on issues referenced by the
  KBE (e.g. refs #N), catching 'don't disable' / 'will investigate'
  signals from the root-cause issue (missed in PR #128737).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 .github/workflows/ci-failure-scan.md | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/ci-failure-scan.md b/.github/workflows/ci-failure-scan.md
index 02270d6b3e1..4544e9fb38a 100644
--- a/.github/workflows/ci-failure-scan.md
+++ b/.github/workflows/ci-failure-scan.md
@@ -259,7 +259,7 @@ Record the same outcomes described there:
 
 #### Step 4.7 — Confirm a test-disable is welcome on the candidate issue
 
-Read the candidate KBE / tracker body + the latest 5 comments (not just the most recent). Skip the test-disable (record `-> skipped: do-not-disable on issue #<n>`) if ANY of:
+Read the candidate KBE / tracker body + the latest 5 comments (not just the most recent). Also read the body + latest 5 comments of ANY issue referenced in the KBE body (e.g. `refs #<n>`, `Tracking: dotnet/runtime#<n>`) — maintainer signals on the root-cause issue override the KBE. Skip the test-disable (record `-> skipped: do-not-disable on issue #<n>`) if ANY of:
 
 - Body or recent comment from any `MEMBER`/`OWNER` mentions one of (case-insensitive): `please don't disable`, `do not mute`, `do not 
... (truncated)

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.