Skip to content

[ci-scan-feedback] Strengthen do-not-disable detection and cross-pipeline dedup #128812

@github-actions

Description

@github-actions

Triggering signals

Proposed edits

Expected behavior change

The next scanner run will skip test-disable PRs when any MEMBER has commented with investigation intent (e.g., "trying to understand", "I'm fixing", "without disabling") on the linked KBE, even when the exact legacy phrase list doesn't match. It will also avoid filing duplicate KBEs when the same failure signature appears across multiple pipeline definitions in the same run.

Generated by CI Outer-Loop Failure Scanner — Feedback · ● 20.6M ·


Note

This was originally intended as a pull request, but the git push operation failed.

Workflow Run: View run details and download patch artifact

The patch file is available in the agent artifact in the workflow run linked above.

To create a pull request with the changes:

# Download the artifact from the workflow run
gh run download 26703914774 -n agent -D /tmp/agent-26703914774

# Create a new branch
git checkout -b ci-scan-feedback/step4.7-phrases-and-crossdef-dedup-aa374e63740f11e5

# Apply the patch (--3way handles cross-repo patches where files may already exist)
git am --3way /tmp/agent-26703914774/aw-ci-scan-feedback-step4.7-phrases-and-crossdef-dedup.patch

# Push the branch to origin
git push origin ci-scan-feedback/step4.7-phrases-and-crossdef-dedup-aa374e63740f11e5

# Create the pull request
gh pr create --title '[ci-scan-feedback] Strengthen do-not-disable detection and cross-pipeline dedup' --base main --head ci-scan-feedback/step4.7-phrases-and-crossdef-dedup-aa374e63740f11e5 --repo dotnet/runtime
Show patch preview (48 of 48 lines)
From 29c8000e5ba18432fbf9118c4203b4750f777ce4 Mon Sep 17 00:00:00 2001
From: "github-actions[bot]" <github-actions[bot]@users.noreply.github.com>
Date: Sun, 31 May 2026 05:17:11 +0000
Subject: [PATCH] ci-failure-scan: strengthen do-not-disable detection and
 cross-def dedup

- Step 4.7: Add 6 new rejection phrases ('should not disable', 'without
  disabling', 'trying to understand', 'I'm fixing', 'I will fix', 'looking
  into this', 'taking a look') plus a heuristic catch-all for MEMBER
  investigation intent.
- Step 4.0: Add cross-definition dedup check so the same signature on
  different pipeline definitions is not filed as separate KBEs.

Signals: PR #128737 closed by @janvorli/@BrzVlad (prefer investigation),
issue #128697 duplicate of #128531 (same OOM signature, different pipeline def).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 .github/workflows/ci-failure-scan.md | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/ci-failure-scan.md b/.github/workflows/ci-failure-scan.md
index 02270d6b..395b6e71 100644
--- a/.github/workflows/ci-failure-scan.md
+++ b/.github/workflows/ci-failure-scan.md
@@ -224,6 +224,8 @@ For each `(definition_id, phase, queue, stress_mode, signature)` produced by Ste
 
 Cache filed signatures in `/tmp/gh-aw/agent/filed.tsv` as `<key>\t<aw_id>` where `key = <definition_id>|<queue>|<stress_mode>|<signature_norm>`. `<signature_norm>` is the signature with tab/newline/CR characters stripped — needed because raw signatures are copied verbatim from logs and may contain whitespace that would corrupt the TSV. On match, record `skipped: dup of filed-issue #aw_<id> earlier in this run` and stop. Append after every Branch A emission.
 
+Additionally, perform a **cross-definition dedup check**: search the cache for any row whose `<signature_norm>` matches the current signature regardless of `<definition_id>`. If found, the same failure shape is already covered by a KBE filed earlie
... (truncated)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions