System.Diagnostics.TraceSource should not be RID specific

[davidfowl]

I don't know the reasoning behind why we chose to compile this thing twice but AFAIK there's a dependency on getting the PID? I'm guess we didn't want to use Process since we're hoping for a more xplat friendly process API. Whatever the reason, runtime light up would be a much better solution here since all of the IL is duplicated in the output of a portable application and the need to cross compile is a very small part of the code.

https://github.com/dotnet/corefx/blob/master/src/System.Diagnostics.TraceSource/src/System/Diagnostics/TraceEventCache.Unix.cs

https://github.com/dotnet/corefx/blob/master/src/System.Diagnostics.TraceSource/src/System/Diagnostics/TraceEventCache.Windows.cs

/cc @stephentoub @ericstj @weshaggard

[stephentoub]

runtime light up would be a much better solution here

Last I checked that doesn't play well with store verification or with .NET Native compilation.

I'm guess we didn't want to use Process

If we're ok layering this library on top of System.Diagnostics.Process.dll, then we can do that and just use Process to get the current process ID.

[weshaggard]

I agree we should try to make this a single IL library. I would actually like to see if we could eliminate the PID as a dependency without too much of an issue. If we cannot we should consider taking a dependency on Process.

@davidfowl out of curiosity why are you using this library it exist primarily as a compat library.

cc @vancem @lt72

[stephentoub]

I would actually like to see if we could eliminate the PID as a dependency without too much of an issue.

FYI, the PID dependency comes from public surface area:
https://github.com/dotnet/corefx/blob/ac67ffac987d0c27236c4a6cf1255c2bcbc7fe7d/src/System.Diagnostics.TraceSource/ref/System.Diagnostics.TraceSource.cs#L141
https://github.com/dotnet/corefx/blob/ac67ffac987d0c27236c4a6cf1255c2bcbc7fe7d/src/System.Diagnostics.TraceSource/ref/System.Diagnostics.TraceSource.cs#L232

[ericstj]

This is covering the same work already described here: https://github.com/dotnet/corefx/issues/7180

[davidfowl]

@davidfowl out of curiosity why are you using this library it exist primarily as a compat library.

Seems like we pull it in in Kestrel. I'm going to remove it now 😄

[weshaggard]

Closing this as it is tracked by #16804.