[API Proposal]: remove dependency on System.Drawing.Common from System.Windows.Extensions

[abelykh0]

Background and motivation

.Net 6 introduced a breaking change in the Windows compatibility (see https://docs.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/6.0/system-drawing-common-windows-only). The motivation is to make the libraries, like the following to not depend on the "not recommended" GDI+ library System.Drawing.Common:
System.Windows.Extensions
System.Security.Permissions
System.Configuration.ConfigurationManager
System.Runtime.Caching
etc

API Proposal

Since so many commonly used packages depend on System.Windows.Extensions, such as System.Security.Permissions, System.Runtime.Caching, and even packages like System.Security.Cryptography and Microsoft.SqlServer.DacFx, it would be beneficial to remove dependency on the "not recommended" library System.Drawing.Common from System.Windows.Extensions.

API Usage

N/A

Alternative Designs

Maybe split System.Drawing.Common into "common" and "GDI+"?

Risks

Backward compatibility

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Tagging subscribers to this area: @dotnet/area-system-drawing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Background and motivation

.Net 6 introduced a breaking change in the Microsoft.Windows.Compatibility (see https://docs.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/6.0/system-drawing-common-windows-only). The motivation is to make the libraries, like the following to not depend on the GDI:
System.Windows.Extensions
System.Security.Permissions
System.Configuration.ConfigurationManager
System.Runtime.Caching
etc

API Proposal

Split Microsoft.Windows.Compatibility into 2 parts:
Microsoft.Windows.Compatibility (NO GDI)
Microsoft.Windows.Compatibility.Gdi

API Usage

N/A

Alternative Designs

No response

Risks

No response

Author:	abelykh0
Assignees:	-
Labels:	api-suggestion, area-System.Drawing, untriaged
Milestone:	-

[safern]

IMHO we shouldn't do this. The compatibility pack was mostly added in order to bring compat in between .NET Framework and .NET Core, so that more apps could move to .NET Core in an easier way and it includes libraries that are only supported on Windows and that throw on non-Windows platforms/mobile platforms. I don't think the deprecation of System.Drawing.Common on non-Windows should change the meaning of the Compatibility pack and we should be giving users feedback on what is supported on which platform via the OSSupported/Unsupported attributes.

@ericstj thoughts?

[abelykh0]

IMHO we shouldn't do this. The compatibility pack was mostly added in order to bring compat in between .NET Framework and .NET Core, so that more apps could move to .NET Core in an easier way and it includes libraries that are only supported on Windows and that throw on non-Windows platforms/mobile platforms. I don't think the deprecation of System.Drawing.Common on non-Windows should change the meaning of the Compatibility pack and we should be giving users feedback on what is supported on which platform via the OSSupported/Unsupported attributes.

@ericstj thoughts?

That is OK with me as long as the libraries such as System.Runtime.Caching will no longer require dependency on System.Drawing.Common.

[teo-tsirpanis]

@abelykh0 if you don't want to reference System.Drawing.Common you can either directly reference the packages you want such as System.Runtime.Caching, or just ignore System.Drawing.Common's existence. The platform compatibility analyzer will inform you if you use a Windows-only component on a cross-platform project, and if you care about your application's deployed size you can ask the trimmer to remove System.Drawing.Common.

[abelykh0]

@abelykh0 if you don't want to reference System.Drawing.Common you can either directly reference the packages you want such as System.Runtime.Caching, or just ignore System.Drawing.Common's existence. The platform compatibility analyzer will inform you if you use a Windows-only component on a cross-platform project, and if you care about your application's deployed size you can ask the trimmer to remove System.Drawing.Common.

I would like to use older version of the System.Drawing.Common (version 4.7.3) and also System.Runtime.Caching version 6.0.0. Please let me know how to do this. Right now I am getting this in Visual Studio:

NU1605: Detected package downgrade: System.Drawing.Common from 6.0.0 to 4.7.3. Reference the package directly from the project to select a different version. 
... -> System.Runtime.Caching 6.0.0 -> System.Configuration.ConfigurationManager 6.0.0 -> System.Security.Permissions 6.0.0 -> System.Windows.Extensions 6.0.0 -> System.Drawing.Common (>= 6.0.0) 
... -> System.Drawing.Common (>= 4.7.3)

[abelykh0]

...The platform compatibility analyzer will inform you if you use a Windows-only component on a cross-platform project...

By the way, this didn't happen, only happens during runtime.

[teo-tsirpanis]

That seems to me as a bug. System.Windows.Extensions does not actually use System.Drawing.Common.

I will prepare a pull request. In the meantime, I think it is safe to ignore the warning.

[abelykh0]

That seems to me as a bug. System.Windows.Extensions does not actually use System.Drawing.Common.

I will prepare a pull request. In the meantime, I think it is safe to ignore the warning.

Thanks! Good news.

[abelykh0]

By the way, which repository should I use to report lack of warning for compatibility analyzer not informing if I used a Windows-only component on a cross-platform project?

[teo-tsirpanis]

I don't know, S.D.C is annotated. Are you targeting .NET 5+? Otherwise you can take a look at https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1416#configure-code-to-analyze.

Oh wait, you are using an old version, that's why it doesn't warn you.

[abelykh0]

I don't know, S.D.C is annotated. Are you targeting .NET 5+? Otherwise you can take a look at https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1416#configure-code-to-analyze.

Oh wait, you are using an old version, that's why it doesn't warn you.

OK, I see. Thanks!