LoggerMessage generator generates invalid code for a parameter

[maxkoshevoi]

Description

Possibly related to #69490

Reproduction Steps

1. Try compiling this code

[LoggerMessage(Level = LogLevel.Information, Message = "No recipients. DiscussionId={DiscussionId} AlertType={AlertType}")]
public static partial void LogNoDicusionRecipients(this ILogger logger, string alertType, int discusionId);

2. See that generator haven't generated var DiscussionId = this._discusionId; line:

Expected behavior

Generator generates valid code

Actual behavior

Generator generates code that doesn't compile

Regression?

No response

Known Workarounds

No response

Configuration

• .NET 6.0.300
• Windows 11
• VS 17.2.2
• Microsoft.Extensions.Logging.Generators 6.0.6.21309

Other information

No response

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Possibly related to #69490

Reproduction Steps

1. Try compiling this code

[LoggerMessage(Level = LogLevel.Information, Message = "No recipients. DiscussionId={DiscussionId} AlertType={AlertType}")]
public static partial void LogNoDicusionRecipients(this ILogger logger, string alertType, int discusionId);

2. See that generator haven't generated var DiscussionId = this._discusionId; line:

Expected behavior

Generator generates valid code

Actual behavior

Generator generates code that doesn't compile

Regression?

No response

Known Workarounds

No response

Configuration

.NET 6.0.300 Windows 11, VS 17.2.2

Other information

No response

Author:	maxkoshevoi
Assignees:	-
Labels:	untriaged, area-Extensions-Logging
Milestone:	-

[martincostello]

Do you have a compiler error or warning somewhere?

There's a typo in your variable name compared to the template string:

discusionId (2xs) vs. DiscussionId (3xs)

If you add an extra s to discusionId (becoming discussionId) it will probably compile.

[maxkoshevoi]

@martincostello Yes, that fixes it, thanks!

I had a SYSLIB1014 Template 'DiscussionId' is not provided as argument to the logging method.

Can source generator make it more explicit that it couldn't match parameter to a log placeholder?
I did get an error that 'DiscussionId' is not provided, but from my point of view, I have provided it, so it was really unobvious, what's wrong.

[maryamariyan]

Seems like the issue was that the message template argument had a typo mismatch with the method variable name. Your recommendation seems like a nice improvement, though I think it is ok to close as it is a low priority improvement.