XmlCustomFormatter is using string.Trim() instead of string.Trim(XmlConverter.WhitespaceChars)

[TrayanZapryanov]

runtime/src/libraries/System.Private.Xml/src/System/Xml/Serialization/Xmlcustomformatter.cs

Line 430 in 97e13f4

value = value.Trim();

This looks more like a mistake than the desired behavior, but it will be a breaking change if we replace it.
String.Trim() is filtering much more characters than :

runtime/src/libraries/System.Private.Xml/src/System/Xml/XmlConvert.cs

Line 1370 in 97e13f4

internal static readonly char[] WhitespaceChars = new char[] { ' ', '\t', '\n', '\r' };

Tagging subscribers to this area: @dotnet/area-system-xml
See info in area-owners.md if you want to be subscribed.

Issue Details

---

runtime/src/libraries/System.Private.Xml/src/System/Xml/Serialization/Xmlcustomformatter.cs

Line 430 in 97e13f4

value = value.Trim();

This looks more like a mistake than the desired behavior, but it will be a breaking change if we replace it.
String.Trim() is filtering much more characters than :

runtime/src/libraries/System.Private.Xml/src/System/Xml/XmlConvert.cs

Line 1370 in 97e13f4

internal static readonly char[] WhitespaceChars = new char[] { ' ', '\t', '\n', '\r' };

Author:	TrayanZapryanov
Assignees:	-
Labels:	area-System.Xml
Milestone:	-

[krwq]

I'd like to add that we trim differently in other places in XML (using WhistespaceChars mentioned above) so it's worth validating if this is correct behavior and if so if we want to change it. Since this behavior has been unchanged for many years and we haven't has any complains I'll change milestone to Future.