[NativeAot] Use ComputeManagedAssemblies Task from ILLink to find managed framework assemblies

[jtschuster]

In NativeAOT builds, we exclude native framework assemblies by relying on the name to end in "*.Native.dll" "msquic.dll".

runtime/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets

Line 159 in 2e77a42

<FrameworkAssemblies Include="$(IlcFrameworkPath)*.dll" Exclude="$(IlcFrameworkPath)*.Native.dll;$(IlcFrameworkPath)msquic.dll" />

It might be more reliable to use the ComputeManagedAssemblies Task from ILLink instead.

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

In NativeAOT builds, we exclude native framework assemblies by relying on the name to end in "*.Native.dll" "msquic.dll".

runtime/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets

Line 159 in 2e77a42

<FrameworkAssemblies Include="$(IlcFrameworkPath)*.dll" Exclude="$(IlcFrameworkPath)*.Native.dll;$(IlcFrameworkPath)msquic.dll" />

It might be more reliable to use the ComputeManagedAssemblies Task from ILLink instead.

Author:	jtschuster
Assignees:	-
Labels:	area-NativeAOT-coreclr
Milestone:	-

[MichalStrehovsky]

We have a task with such check here:

runtime/src/coreclr/tools/aot/ILCompiler.Build.Tasks/ComputeManagedAssembliesToCompileToNative.cs

Lines 156 to 174 in e2d192a

	using (FileStream moduleStream = File.OpenRead(itemSpec))
	using (var module = new PEReader(moduleStream))
	{
	if (module.HasMetadata)
	{
	MetadataReader moduleMetadataReader = module.GetMetadataReader();
	if (moduleMetadataReader.IsAssembly)
	{
	string culture = moduleMetadataReader.GetString(moduleMetadataReader.GetAssemblyDefinition().Culture);
	assembliesToSkipPublish.Add(taskItem);
	if (culture == "" || culture.Equals("neutral", StringComparison.OrdinalIgnoreCase))
	{
	// NativeAOT doesn't consume resource assemblies yet so skip them
	list.Add(taskItem);
	}
	}
	}
	}

We just don't do the check on the framework assemblies because those are special.

The framework assemblies might go away if @sbomer gets #80003 through.

The logic is currently more complicated than it needs to be because it was all inherited from CoreRT that was an addon to the SDK - it came with its own customized version of the framework and the SDK wasn't aware of it. A lot of what the targets/tasks are doing can be simplified.