[EmailAddress] DataAnnotations not work correctly with user@example without .com

[mammadkoma]

Is there an existing issue for this?

• I have searched the existing issues
  test.zip

Describe the bug

[EmailAddress] DataAnnotations not work correctly with user@example without .com

using System.ComponentModel.DataAnnotations;
using Microsoft.AspNetCore.Mvc;

namespace test.Controllers;

[ApiController]
[Route("[controller]/[action]")]
public class WeatherForecastController : ControllerBase
{
[HttpPost]
public IActionResult GetAll([FromBody] MyViewModel myViewModel)
{
if (ModelState.IsValid)
return Ok("Valid");
else return Ok("Not Valid");
}
}
public class MyViewModel
{
public int Id { get; set; }

[EmailAddress]
public required string Email { get; set; }

}

Expected Behavior

When we send this json on the body with swagger:
{ "id": 1, "email": "user@example" }
The GetAll() action method have to return "Not Valid"

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

7.0.201

Anything else?

<PropertyGroup>
  <TargetFramework>net7.0</TargetFramework>
  <Nullable>enable</Nullable>
  <ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup>

<ItemGroup>
  <PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="7.0.3" />
  <PackageReference Include="Swashbuckle.AspNetCore" Version="6.4.0" />
</ItemGroup>

</Project>

[pinkfloydx33]

The only validation that the EmailAddressAttribute performs is whether or not the value contains a single @ symbol which is also not the first/last character.

If you need any more than that, you'd have to define your own attribute. We did something similar as we needed values to conform to Auth0's e-mail address format/specification. It's not too hard, and you can leverage the MailAddress class for a bit of help.

Other than that, this would be a runtime issue and not aspnet since that's where the attribute lives. However improvements have been requested before and declined. You can find a reference implementation in a closed issue from 2021, which was marked as a duplicate of an issue from 2018.

[mammadkoma]

The only validation that the EmailAddressAttribute performs is whether or not the value contains a single @ symbol which is also not the last character.

If you need any more than that, you'd have to define your own attribute. We did something similar as we needed values to conform to Auth0's e-mail address format/specification. It's not too hard, and you can leverage the MailAddress class for a bit of help.

Other than that, this would be a runtime issue and not aspnet since that's where the attribute lives. However improvements have been requested before and declined. You can find a reference implementation in a closed issue from 2021, which was marked as a duplicate of an issue from 2018.

So add [FullEmail] attribute to the .net

Tagging subscribers to this area: @ajcvickers, @bricelam, @roji
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Is there an existing issue for this?

• I have searched the existing issues
  test.zip

Describe the bug

[EmailAddress] DataAnnotations not work correctly with user@example without .com

using System.ComponentModel.DataAnnotations;
using Microsoft.AspNetCore.Mvc;

namespace test.Controllers;

[ApiController]
[Route("[controller]/[action]")]
public class WeatherForecastController : ControllerBase
{
[HttpPost]
public IActionResult GetAll([FromBody] MyViewModel myViewModel)
{
if (ModelState.IsValid)
return Ok("Valid");
else return Ok("Not Valid");
}
}
public class MyViewModel
{
public int Id { get; set; }

[EmailAddress]
public required string Email { get; set; }

}

Expected Behavior

When we send this json on the body with swagger:
{ "id": 1, "email": "user@example" }
The GetAll() action method have to return "Not Valid"

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

7.0.201

Anything else?

<PropertyGroup>
  <TargetFramework>net7.0</TargetFramework>
  <Nullable>enable</Nullable>
  <ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup>

<ItemGroup>
  <PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="7.0.3" />
  <PackageReference Include="Swashbuckle.AspNetCore" Version="6.4.0" />
</ItemGroup>

</Project>

Author:	mammadkoma
Assignees:	-
Labels:	area-System.ComponentModel.DataAnnotations
Milestone:	-

[eiriktsarpalis]

I believe that technically user@tld is valid address syntax, but it's not permitted as a matter of policy. Regardless, strengthening the validator at this stage would most likely be a breaking change, so it's not something that would be worth the risk. I would recommend writing your own validation attribute, since it's fairly straightforward to do so.