[PERF] Remove lttng-modules-dkms package at beginning of microbenchmark runs#101142
Merged
LoopedBard3 merged 2 commits intodotnet:mainfrom Apr 16, 2024
Merged
Conversation
…microbenchmarking runs to fail.
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
…run as part of the regular linux commands.
caaavik-msft
approved these changes
Apr 16, 2024
Contributor
caaavik-msft
left a comment
caaavik-msft
left a comment
There was a problem hiding this comment.
LGTM to get pipelines working again, but we should create an issue to track fixing this properly.
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…rk runs (dotnet#101142) Add removal of lttng-modules-dkms package as it is currently causing microbenchmarking runs to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add removal of lttng-modules-dkms package as it is currently causing microbenchmarking runs to fail.
Should fix: dotnet/performance#4149
The removal of the lttng-modules-dkms package using the set command causes the python3-pip package install command to succeed instead of failing as it currently is. This will likely have an impact on our scenario testing that uses Lttng (non-microbenchmarks) as I was unable to get a clean install of the lttng-modules-dkms package on both the 6.5.0-27 and -26 kernels.