Bugfix InvalidOperationException/IndexOutOfRangeException in HttpListener.EndGetContext #107804
Conversation
…ust have exclusive access
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
@dotnet-policy-service agree [company="Jannesen"] |
@dotnet-policy-service agree company="Jannesen" |
| } | ||
| lock ((DisconnectResults as ICollection).SyncRoot) | ||
|
|
||
| var disconnectResults = DisconnectResults; |
There was a problem hiding this comment.
The local variable isn't helpful as it doesn't contain any common expression.
There was a problem hiding this comment.
Definition of DisconnectResults
private Dictionary<ulong, DisconnectAsyncResult> DisconnectResults =>
LazyInitializer.EnsureInitialized(ref _disconnectResults, () => new Dictionary<ulong, DisconnectAsyncResult>());So every access of DisconnectResults is a call to LazyInitializer.EnsureInitialized.
So using the local variable only one call is necessary.
There was a problem hiding this comment.
What do you want to do?
Remove the local variable and directly access DisconnectResults (this will result in more Volatile.Read of _disconnectResults) or do you have another comment.
There was a problem hiding this comment.
HttpListener isn't so optimized. I don't think reducing several volatile reads can result in real world difference. Let's focus on fixing only.
|
Tagging subscribers to this area: @dotnet/ncl |
|
Thanks for the contribution! I'll take a look at this PR, asap! |
liveans
left a comment
liveans
left a comment
There was a problem hiding this comment.
Change LGTM in general, but I also think that if we should consider using ConcurrentDictionary instead of Dictionary and locking it with SyncRoot everywhere. However, that's another PR's concern, IMO.
…ust have exclusive access (dotnet#107804)
…ust have exclusive access (dotnet#107804)
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/12317158203 |
|
@rokonec an error occurred while backporting to release/9.0, please check the run log for details! Error: @rokonec is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=rokonec |
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/12317257049 |
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: #110695 |
5 participants
Fixes #107025