Skip to content

Comments

Refactor use of FastAllocateString#110929

Closed
xtqqczze wants to merge 1 commit intodotnet:mainfrom
xtqqczze:FastAllocateString2
Closed

Refactor use of FastAllocateString#110929
xtqqczze wants to merge 1 commit intodotnet:mainfrom
xtqqczze:FastAllocateString2

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Dec 24, 2024

No description provided.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Dec 24, 2024
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 24, 2024

@MihuBot

@MihuBot MihuBot mentioned this pull request Dec 24, 2024
Open
EgorBo
EgorBo reviewed Dec 24, 2024
View reviewed changes
src/libraries/System.Private.CoreLib/src/System/String.cs
string result = FastAllocateString(length);
resultSpan = new Span<char>(ref result._firstChar, result.Length);
return result;
}
Copy link
Member

@EgorBo EgorBo Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rather use string.Create everywhere?

Copy link
Member

@huoyaoyuan huoyaoyuan Dec 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the delegate can be inlined everywhere, otherwise there may be performance hot spots?

This was referenced Dec 24, 2024
Closed
Open
Closed
@jkotas
Copy link
Member

jkotas commented Dec 25, 2024

What are you trying to achieve with this refactoring?

@stephentoub stephentoub added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 6, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jan 20, 2025

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Feb 3, 2025

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBo EgorBo EgorBo left review comments

+1 more reviewer

@huoyaoyuan huoyaoyuan huoyaoyuan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xtqqczze @jkotas @EgorBo @huoyaoyuan @stephentoub