[HttpStress] Re-enable ASAN for msquic#113669
Conversation
|
Tagging subscribers to this area: @dotnet/ncl |
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
antonfirsov
changed the title
| # configure adress sanitizer | ||
| # ENV ASAN_OPTIONS='detect_leaks=0' | ||
| # ENV LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/12/libasan.so | ||
| ENV ASAN_OPTIONS='detect_leaks=0' |
There was a problem hiding this comment.
You should grab all of the options we return from __asan_default_options in the minipal. That has the complete list of the options required to use ASAN with CoreCLR.
There was a problem hiding this comment.
We are only building msquic in this Dockerfile. CoreCLR is built without ASAN for HttpStress.
There was a problem hiding this comment.
Yes, but the ASAN_OPTIONs along with the LD_PRELOAD influence the whole process, so the options incompatible with CoreCLR should be disabled.
There was a problem hiding this comment.
Addressed in 63123d1. Hope it is how it should be, I don't have a deep understanding on these flags.
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
antonfirsov
changed the title
| # ENV LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/12/libasan.so | ||
| # Make sure ASAN_OPTIONS are compatible with CoreCLR: https://github.com/dotnet/runtime/blob/300485de6f5bf52c28192da930e1aa79cfef46df/src/native/minipal/sansupport.c#L18 | ||
| ENV ASAN_OPTIONS='symbolize=1 use_sigaltstack=0 detect_leaks=0 handle_segv=0 allocator_may_return_null=1' | ||
| ENV LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/13/libasan.so |
There was a problem hiding this comment.
@rzikm the key was to bump the gcc version in this path
|
/ba-g CI failures are unrelated (different pipelines) |
Experiments to address #111854