Update SuperPMI collection helix queues #113884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match what is in eng\pipelines\coreclr\templates\helix-queues-setup.yml
ghost
added
the
area-CodeGen-coreclr
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SuperPMI collection helix queue assignments to match the configuration in eng/pipelines/coreclr/templates/helix-queues-setup.yml.
- Updated helix queue names for public and internal builds across Windows, Linux, and OSX.
- Revised version numbers and string formats to align with the updated templates.
Comments suppressed due to low confidence (2)
src/coreclr/scripts/superpmi_collect_setup.py:473
- [nitpick] The queue value 'osx.13.arm64.open' uses a lowercase prefix while other OSX queue names are uppercased (e.g., 'OSX.1200.Amd64.Open'); please verify if this inconsistency is intentional.
helix_queue = "osx.13.arm64.open"
src/coreclr/scripts/superpmi_collect_setup.py:488
- [nitpick] The internal Linux x64 queue value 'azurelinux.3.amd64' does not include the '.open' suffix seen in the public version ('azurelinux.3.amd64.open'); please verify that this difference is intended.
helix_queue = "azurelinux.3.amd64"
Contributor
Author
|
/azp run runtime-coreclr superpmi-collect-test |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 25, 2025
Contributor
Author
|
@kunalspathak @dotnet/jit-contrib PTAL The superpmi-collect-test run looks pretty good. |
amanasifkhalid
approved these changes
Mar 26, 2025
Contributor
amanasifkhalid
left a comment
amanasifkhalid
left a comment
There was a problem hiding this comment.
LGTM. The superpmi-collect-test failures are some known libraries issues, plus the usual libraries timeouts on macOS arm64.
Contributor
Author
|
/ba-g unrelated failures |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match what is in eng\pipelines\coreclr\templates\helix-queues-setup.yml