Include in WaitingWriteCount the thread that may be waiting in upgradable mode #113982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the WaitingWriteCount property in ReaderWriterLockSlim so that it includes the thread potentially waiting in upgradable mode, addressing issue #107077.
- Added a comment explaining the inclusion of upgradable mode waiters.
- Adjusted the WaitingWriteCount property to sum _numWriteWaiters and _numWriteUpgradeWaiters.
Comments suppressed due to low confidence (1)
src/libraries/System.Private.CoreLib/src/System/Threading/ReaderWriterLockSlim.cs:1416
- Verify that _numWriteWaiters and _numWriteUpgradeWaiters are updated under the same concurrency control mechanism to prevent potential race conditions when summing their values.
public int WaitingWriteCount => (int)_numWriteWaiters + (int)_numWriteUpgradeWaiters;
This was referenced Mar 27, 2025
mangod9
approved these changes
Mar 28, 2025
eduardo-vp
force-pushed
the
fix-ReaderWriterLockSlim-WaitingWriteCount
branch
from
bc7881b to
4457707
Compare
kouvel
approved these changes
Mar 28, 2025
This was referenced Mar 28, 2025
Member
Author
|
/ba-g Test failures are not related to this change. |
thaystg
pushed a commit
to thaystg/runtime
that referenced
this pull request
Apr 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107077.