Skip to content

Share common Uri redaction logic in Http#114483

Merged
MihaZupan merged 2 commits intodotnet:mainfrom
MihaZupan:http-redaction-unified
Apr 10, 2025
Merged

Share common Uri redaction logic in Http#114483
MihaZupan merged 2 commits intodotnet:mainfrom
MihaZupan:http-redaction-unified

Conversation

@MihaZupan
Copy link
Copy Markdown
Member

We had duplicate logic between the client factory and http, and the Redirect redaction was different (didn't account for user info & fragment).

This makes all the places share the same logic.

@MihaZupan MihaZupan added this to the 10.0.0 milestone Apr 10, 2025
Copilot AI review requested due to automatic review settings April 10, 2025 11:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • src/libraries/Microsoft.Extensions.Http/src/Microsoft.Extensions.Http.csproj: Language not supported
  • src/libraries/System.Net.Http/src/System.Net.Http.csproj: Language not supported
  • src/libraries/System.Net.Http/tests/UnitTests/System.Net.Http.Unit.Tests.csproj: Language not supported
Comments suppressed due to low confidence (1)

src/libraries/System.Net.Http/tests/FunctionalTests/TelemetryTest.cs:937

  • [nitpick] Verify that the computed expectedUriTail correctly reflects the updated redaction behavior (i.e. excluding any URI fragments) and aligns with the new centralized logic in UriRedactionHelper.
string expectedUriTail = uriTail;

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@MihaZupan MihaZupan requested a review from a team April 10, 2025 11:23
Co-authored-by: Anton Firszov <antonfir@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants